Fix compile errors for KAFKA-12543 #10719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrao
reviewed
May 18, 2021
| "Unable to close snapshot reader %s at %s", | ||
| snapshotId, | ||
| fileRecords.file | ||
| fileRecords |
Contributor
There was a problem hiding this comment.
Do we need to define the toString() method for FileRecords so that it prints well?
Member
There was a problem hiding this comment.
I checked. toString is defined for FileRecords. It looks like it has enough information to debug the issue.
| expiredSnapshots.foreach { case (snapshotId, snapshotReader) => | ||
| snapshotReader.foreach { reader => | ||
| CoreUtils.swallow(reader.close(), this) | ||
| CoreUtils.swallow(reader.close(), logging) |
Contributor
There was a problem hiding this comment.
This is an existing issue. But CoreUtils.swallow() doesn't seem to need logging.
Member
|
LGTM. Compiles locally and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for two compiler errors which were introduced in #10431