MINOR: Add missing apiversion test for 3.0 #10748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @mumrah for a review, maybe you forgot it. |
dengziming
force-pushed
the
minor-apiversion-test
branch
2 times, most recently
from
b4703bc to
9c1affb
Compare
dengziming
force-pushed
the
minor-apiversion-test
branch
from
9c1affb to
8378ffe
Compare
Member
Author
|
I also find #10760 bumped the IBP to V3.0.1 but forgot to add a test for it. ping @thomaskwscott @dajac to have a look. |
Contributor
thanks for the catch @dengziming, lgtm |
Member
|
@dengziming Good catch! |
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
Reviewers: Luke Chen <showuon@gmail.com>, David Jacot <djacot@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
#10504 bump apiversion to 3.0.0, we'd better also add test for it.
Summary of testing strategy (including rationale)
Unit test