MINOR: Adjust parameter ordering of waitForCondition and retryOnExceptionWithTimeout#10759
Merged
ijuma merged 1 commit intoapache:trunkfrom May 27, 2021
Merged
Conversation
…ceptionWithTimeout` New parameters in overloaded methods should appear later apart from lambdas that should always be last.
chia7712
approved these changes
May 26, 2021
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
+1 if those methods exist only in trunk branch. Otherwise, reordering arguments could make trouble when we backport patch to other branches.
showuon
approved these changes
May 27, 2021
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
LGTM! Failed tests are flaky. Thanks.
Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
Build / JDK 8 and Scala 2.12 / kafka.admin.DeleteOffsetsConsumerGroupCommandIntegrationTest.testDeleteOffsetsNonExistingGroup()
Build / JDK 8 and Scala 2.12 / kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete()
Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 27, 2021
…ceptionWithTimeout` (apache#10759) New parameters in overloaded methods should appear later apart from lambdas that should always be last.
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 27, 2021
…nups * apache-github/trunk: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout` (apache#10759) KAFKA-12796: Removal of deprecated classes under streams-scala (apache#10710) KAFKA-12819: Add assert messages to MirrorMaker tests plus other quality of life improvements (apache#10762) Update implementation.html (apache#10771) MINOR: Log constructor: Flip logical NOT for readability (apache#10756) MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide (apache#10755) MINOR: Log more information when producer snapshot is written (apache#10757) KAFKA-12260: Avoid hitting NPE for partitionsFor (apache#10017) MINOR: add window verification to sliding-window co-group test (apache#10745) KAFKA-12800: Configure generator to fail on trailing JSON tokens (apache#10717)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New parameters in overloaded methods should appear later apart from
lambdas that should always be last.
Committer Checklist (excluded from commit message)