KAFKA-12436 KIP-720 Deprecate MirrorMaker v1 #10805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
showuon
reviewed
Jun 2, 2021
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
@ryannedolan , thanks for the PR. Left a comment. Thanks.
ijuma
reviewed
Jun 4, 2021
Member
|
This KIP was adopted on the basis of having an IdentityReplicationPolicy which is in this PR: #10652 |
Contributor
Author
|
@ijuma can we merge this? |
ijuma
reviewed
Jul 1, 2021
|
|
||
| import scala.annotation.nowarn | ||
|
|
||
| @nowarn("cat=deprecation") |
Member
There was a problem hiding this comment.
Can we deprecate the test too instead of the warning suppression?
Contributor
Author
There was a problem hiding this comment.
good call, done!
Member
|
@mimaison were you planning to merge this? |
Contributor
Author
|
I added a short note to the changelog. |
mimaison
reviewed
Jul 4, 2021
docs/upgrade.html
Outdated
| replication topology. | ||
| </li> | ||
| <li> The original MirrorMaker (MM1) and related classes have been deprecated. Please use the Connect-based | ||
| MirrorMaker (MM2), as described in <a href="/{{version}}/documentation/#georeplication">. |
Member
There was a problem hiding this comment.
<a href="/{{version}}/documentation/#georeplication"> should be the <a href="/{{version}}/documentation/#georeplication">Geo-Replication section</a>
mimaison
approved these changes
Jul 4, 2021
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
Reviewers: Luke Chen <showuon@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Mickael Maison <mickael.maison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per KIP-720, add deprecation warnings to legacy mirror maker.