MINOR: replace deprecated exactly_once_beta into exactly_once_v2 by showuon · Pull Request #10884 · apache/kafka

showuon · 2021-06-15T07:27:23Z

replace deprecated exactly_once_beta into exactly_once_v2 in system tests.

Follow up for #10870, found out there are still some system tests using the deprecated exactly_once_beta. Update them.

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

showuon · 2021-06-15T07:27:59Z

tests/kafkatest/tests/streams/streams_broker_compatibility_test.py


-    # TODO enable after 2.5 is released
-    # @parametrize(broker_version=str(LATEST_2_5))
-    # def test_compatible_brokers_eos_beta_enabled(self, broker_version):


We forgot to enable it after V2.5. Enable it now.

showuon · 2021-06-15T07:28:35Z

@vvcephei , please help review this PR. Thanks.

showuon · 2021-06-22T08:43:19Z

All failed tests are unrelated.

    Build / JDK 16 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
    Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()

showuon · 2021-06-22T08:43:39Z

@vvcephei @mjsax , could you help review? Thank you.

showuon · 2021-07-01T05:19:02Z

@vvcephei @mjsax , could you help review? Thank you

showuon · 2021-07-06T13:43:36Z

@cadonna , I saw you were updating system tests last week, you might want to check this PR. Thanks.

cadonna

Thanks for the PR, @showuon !

When I run these system tests, I get

TimeoutError("Kafka server didn't finish startup in 60 seconds")

reliably for 2.8 and 3.0.

showuon · 2021-07-13T09:47:30Z

Interesting. I'll take a look. Thanks.

…stEosUpdate

showuon · 2021-07-19T11:31:14Z

@cadonna , sorry, it turns out the version LATEST_3_0 cannot be tested yet. Remove it to make it work. Thank you.

SESSION REPORT (ALL TESTS)
ducktape version: 0.8.1
session_id:       2021-07-19--014
run time:         3 minutes 0.207 seconds
tests run:        4
passed:           4
failed:           0
ignored:          0
================================================================================
test_id:    kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.5.1
status:     PASS
run time:   45.659 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.6.2
status:     PASS
run time:   42.687 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.7.1
status:     PASS
run time:   45.178 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.8.0
status:     PASS
run time:   46.120 seconds
--------------------------------------------------------------------------------

…stEosUpdate

showuon · 2021-09-27T07:54:51Z

@cadonna , please help take a look when available, to enable an ignored system test, and update the deprecated exactly_once_beta to exactly_once_v2. Thank you.

cadonna · 2021-09-27T08:45:53Z

@showuon Thank you for the ping! I started the system tests on this branch. If they are green, I will merge.

cadonna · 2021-09-27T15:00:32Z

System tests passed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4694/console

Build failures are unrelated.

cadonna

LGTM!

…che#10884) Replace deprecated exactly_once_beta with exactly_once_v2 in system tests. Follow up for apache#10870, found out there are still some system tests using the deprecated exactly_once_beta. This PR updates them. Reviewers: Bruno Cadonna <cadonna@apache.org>

replace deprecated exactly_once_beta into exactly_once_v2

c678020

showuon commented Jun 15, 2021

View reviewed changes

use exactly_once_v2

364827a

cadonna reviewed Jul 12, 2021

View reviewed changes

showuon added 2 commits July 19, 2021 17:57

Merge branch 'trunk' of https://github.com/apache/kafka into systemTe…

d458654

…stEosUpdate

remove unreleased LATEST_3_0

0d0718c

Merge branch 'trunk' of https://github.com/apache/kafka into systemTe…

2bc5667

…stEosUpdate

cadonna approved these changes Sep 27, 2021

View reviewed changes

cadonna merged commit 1af1c80 into apache:trunk Sep 27, 2021

Comments

Conversation

showuon commented Jun 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Committer Checklist (excluded from commit message)

Uh oh!

showuon Jun 15, 2021

Choose a reason for hiding this comment

Uh oh!

showuon commented Jun 15, 2021

Uh oh!

showuon commented Jun 22, 2021

Uh oh!

showuon commented Jun 22, 2021

Uh oh!

showuon commented Jul 1, 2021

Uh oh!

showuon commented Jul 6, 2021

Uh oh!

cadonna left a comment

Choose a reason for hiding this comment

Uh oh!

showuon commented Jul 13, 2021

Uh oh!

showuon commented Jul 19, 2021

Uh oh!

showuon commented Sep 27, 2021

Uh oh!

cadonna commented Sep 27, 2021

Uh oh!

cadonna commented Sep 27, 2021

Uh oh!

cadonna left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

showuon commented Jun 15, 2021 •

edited

Loading