Skip to content

KAFKA-13081: detect doubly assigned parition (for v2.8)#11068

Merged
ableegoldman merged 1 commit intoapache:2.8from
showuon:KAFKA-13081
Aug 19, 2021
Merged

KAFKA-13081: detect doubly assigned parition (for v2.8)#11068
ableegoldman merged 1 commit intoapache:2.8from
showuon:KAFKA-13081

Conversation

@showuon
Copy link
Member

@showuon showuon commented Jul 16, 2021

This is the fix 1 and fix 2 in #10985 for v2.8, including the tests.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon showuon changed the title KAFKA-13081: detect doubly assigned parition KAFKA-13081: detect doubly assigned parition (for v2.8) Jul 16, 2021
@showuon
Copy link
Member Author

showuon commented Jul 24, 2021

@ableegoldman , please take a look. Thank you.

Failed tests are unrelated.

Build / ARM / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 8 and Scala 2.12 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 8 and Scala 2.12 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 8 and Scala 2.12 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 8 and Scala 2.12 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true

Copy link
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ableegoldman ableegoldman merged commit 3d764ed into apache:2.8 Aug 19, 2021
hachikuji pushed a commit that referenced this pull request Oct 19, 2021
…ive assignor (#11068)

This is the fix 1 and fix 2 in #10985 for v2.7, including the tests. Uses the generation to invalidate previous assignments that claim partitions but no longer own them, and implements an additional safety net to handle any case in which doubly-claimed partitions slip in to the input anyway

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
hachikuji pushed a commit that referenced this pull request Oct 19, 2021
…ive assignor (#11068)

This is the fix 1 and fix 2 in #10985 for v2.6, including the tests. Uses the generation to invalidate previous assignments that claim partitions but no longer own them, and implements an additional safety net to handle any case in which doubly-claimed partitions slip in to the input anyway

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
hachikuji pushed a commit that referenced this pull request Oct 19, 2021
…ive assignor (#11068)

This is the fix 1 and fix 2 in #10985 for v2.6, including the tests. Uses the generation to invalidate previous assignments that claim partitions but no longer own them, and implements an additional safety net to handle any case in which doubly-claimed partitions slip in to the input anyway

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
andrewegel pushed a commit to confluentinc/kafka that referenced this pull request Oct 22, 2021
…ive assignor (apache#11068)

This is the fix 1 and fix 2 in apache#10985 for v2.6, including the tests. Uses the generation to invalidate previous assignments that claim partitions but no longer own them, and implements an additional safety net to handle any case in which doubly-claimed partitions slip in to the input anyway

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants