KAFKA-13591; Fix flaky test ControllerIntegrationTest.testTopicIdCreatedOnUpgrade#11666
Merged
dajac merged 2 commits intoapache:trunkfrom Jan 21, 2022
Merged
KAFKA-13591; Fix flaky test ControllerIntegrationTest.testTopicIdCreatedOnUpgrade#11666dajac merged 2 commits intoapache:trunkfrom
ControllerIntegrationTest.testTopicIdCreatedOnUpgrade#11666dajac merged 2 commits intoapache:trunkfrom
Conversation
hachikuji
reviewed
Jan 13, 2022
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks. The patch makes sense. Left a minor suggestion.
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
Outdated
Show resolved
Hide resolved
3 tasks
dajac
added a commit
that referenced
this pull request
Jan 21, 2022
…atedOnUpgrade` (#11666) The issue is that when `zkClient.getTopicIdsForTopics(Set(tp.topic)).get(tp.topic)` is called after the new controller is brought up, there is not guarantee that the controller has already written the topic id to the topic znode. Reviewers: Jason Gustafson <jason@confluent.io>
jeffkbkim
pushed a commit
to confluentinc/kafka
that referenced
this pull request
May 12, 2022
…atedOnUpgrade` (apache#11666) The issue is that when `zkClient.getTopicIdsForTopics(Set(tp.topic)).get(tp.topic)` is called after the new controller is brought up, there is not guarantee that the controller has already written the topic id to the topic znode. Reviewers: Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that when
zkClient.getTopicIdsForTopics(Set(tp.topic)).get(tp.topic)is called after the new controller is brought up, there is not guarantee that the controller has already written the topic id to the topic znode.Committer Checklist (excluded from commit message)