Skip to content

KAFKA-10000: Add new metrics for source task transactions (KIP-618) #11772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 1 commit into from
Feb 23, 2022
Merged

KAFKA-10000: Add new metrics for source task transactions (KIP-618) #11772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion checkstyle/suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
files="(JsonConverter|Values|ConnectHeaders).java"/>

<suppress checks="JavaNCSS"
files="(KafkaConfigBackingStore|Values).java"/>
files="(KafkaConfigBackingStore|Values|ConnectMetricsRegistry).java"/>

<suppress checks="NPathComplexity"
files="(DistributedHerder|RestClient|RestServer|JsonConverter|KafkaConfigBackingStore|FileStreamSourceTask|TopicAdmin).java"/>
Expand Down
13 changes: 13 additions & 0 deletions connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ public class ConnectMetricsRegistry {
public final MetricNameTemplate dlqProduceRequests;
public final MetricNameTemplate dlqProduceFailures;
public final MetricNameTemplate lastErrorTimestamp;
public final MetricNameTemplate transactionSizeMin;
public final MetricNameTemplate transactionSizeMax;
public final MetricNameTemplate transactionSizeAvg;

public Map<MetricNameTemplate, TaskStatus.State> connectorStatusMetrics;

Expand Down Expand Up @@ -207,6 +210,16 @@ public ConnectMetricsRegistry(Set<String> tags) {
"completely written to Kafka.",
sourceTaskTags);

transactionSizeMin = createTemplate("transaction-size-min", SOURCE_TASK_GROUP_NAME,
"The number of records in the smallest transaction the task has committed so far. ",
sourceTaskTags);
transactionSizeMax = createTemplate("transaction-size-max", SOURCE_TASK_GROUP_NAME,
"The number of records in the largest transaction the task has committed so far.",
sourceTaskTags);
transactionSizeAvg = createTemplate("transaction-size-avg", SOURCE_TASK_GROUP_NAME,
"The average number of records in the transactions the task has committed so far.",
sourceTaskTags);

/***** Sink worker task level *****/
Set<String> sinkTaskTags = new LinkedHashSet<>(tags);
sinkTaskTags.add(CONNECTOR_TAG_NAME);
Expand Down