Skip to content

Conversation

@C0urante
Copy link
Contributor

@C0urante C0urante commented Feb 17, 2022

Adds some reusable utility methods for KIP-618 that facilitate:

  • Overriding (and logging a warning) user-supplied properties if they do not contain an expected value
  • Generating an array of the names (or, to be precise, toString representations) of every known value for an enumerable type (which is useful for defining ConfigDef validators in conjunction with existing validators such as CaseInsensitiveValidString)

Note that these utility methods are not used in this PR. They will be used in downstream PRs.

Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimaison mimaison merged commit 6f09c3f into apache:trunk Feb 23, 2022
@C0urante C0urante deleted the kafka-10000-utils branch February 23, 2022 13:52
@C0urante
Copy link
Contributor Author

Thanks Mickael!

yyu1993 added a commit to confluentinc/kafka that referenced this pull request Feb 25, 2022
* apache-kafka/trunk: (49 commits)
  KAFKA-12738: send LeaveGroup request when thread dies to optimize replacement time (apache#11801)
  MINOR: Skip fsync on parent directory to start Kafka on ZOS (apache#11793)
  KAFKA-12738: track processing errors and implement constant-time task backoff (apache#11787)
  MINOR: Cleanup admin creation logic in integration tests (apache#11790)
  KAFKA-10199: Add interface for state updater (apache#11499)
  KAFKA-10000: Utils methods for overriding user-supplied properties and dealing with Enum types (apache#11774)
  KAFKA-10000: Add new metrics for source task transactions (apache#11772)
  KAFKA-13676: Commit successfully processed tasks on error (apache#11791)
  KAFKA-13511: Add support for different unix precisions in TimestampConverter SMT (apache#11575)
  MINOR: Improve Connect docs (apache#11642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants