KAFKA-12738: address minor followup and consolidate integration tests of PR #11787 #11812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcarlson5
approved these changes
Feb 26, 2022
Contributor
wcarlson5
left a comment
wcarlson5
left a comment
There was a problem hiding this comment.
LGTM just a couple of nits!
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadata.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| public void shouldEmitSameRecordAfterFailover() throws Exception { |
Contributor
There was a problem hiding this comment.
Nice move, this really does belong in this class
| streams.setUncaughtExceptionHandler(exception -> StreamThreadExceptionResponse.REPLACE_THREAD); | ||
|
|
||
| final NamedTopologyBuilder builder = streams.newNamedTopologyBuilder("topology_A"); | ||
| builder.stream(DELAYED_INPUT_STREAM_1).peek((k, v) -> outputExpected.incrementAndGet()).to(OUTPUT_STREAM_1); |
Contributor
There was a problem hiding this comment.
would it be useful to have a second named topology as well to process data and make sure it makes progress?
Member
Author
There was a problem hiding this comment.
Ah yeah I meant to add a second integration test variant that's FromDifferentTopologies instead of WithinSameTopology -- but I'm still working on it, so I didn't want to block this PR on it necessarily. But short answer is "yes", definitely
guozhangwang
approved these changes
Mar 1, 2022
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM! This is a great move.
Member
Author
|
Test failures are unrelated, will merge |
Member
Author
|
Merged to trunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the remaining nits from the final review of #11787
It also deletes two integration test classes which had only one test in them, and moves the tests to another test class file to save on the time to bring up an entire embedded kafka cluster just for a single run