Skip to content

MINOR: remove kafka-preferred-replica-election.sh in doc#11954

Merged
showuon merged 1 commit intoapache:trunkfrom
showuon:preferredReplica
Mar 27, 2022
Merged

MINOR: remove kafka-preferred-replica-election.sh in doc#11954
showuon merged 1 commit intoapache:trunkfrom
showuon:preferredReplica

Conversation

@showuon
Copy link
Member

@showuon showuon commented Mar 27, 2022

We've removed kafka-preferred-replica-election.sh in #10443 , but we forgot to update the doc. Fix it.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Member Author

showuon commented Mar 27, 2022

@dajac , one line PR to fix the doc script. Please take a look. Thanks.

Copy link
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@showuon showuon merged commit ca3271e into apache:trunk Mar 27, 2022
@showuon
Copy link
Member Author

showuon commented Mar 27, 2022

Thanks @dajac !

@dajac
Copy link
Member

dajac commented Mar 27, 2022

@showuon You’ve put yourself as reviewer of the PR :).

@showuon
Copy link
Member Author

showuon commented Mar 27, 2022

Oh... NO!! Sorry! I'll be careful next time. Should we do anything to it?

@dajac
Copy link
Member

dajac commented Mar 27, 2022

No worries. It happened to me as well. You can’t do much for it.

karuturi pushed a commit to karuturi/kafka that referenced this pull request Apr 27, 2022
…election.sh (apache#11954)

Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants