Skip to content

KAFKA-12943: update aggregating documentation#12091

Merged
mjsax merged 1 commit intoapache:trunkfrom
MarcoLotz:KAFKA-12943
Jul 7, 2022
Merged

KAFKA-12943: update aggregating documentation#12091
mjsax merged 1 commit intoapache:trunkfrom
MarcoLotz:KAFKA-12943

Conversation

@MarcoLotz
Copy link
Contributor

Regarding documentation glitch reported in KAFKA-12943, indeed implicit types are not automatically resolved unless explicitly defined in this case.

As confirmed in:
https://stackoverflow.com/questions/51040555/the-method-withvalueserde-in-the-type-materialized-is-not-applicable/51049472

Copy link
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoLotz , thanks for the fix. Left some comments.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please escape the < and > with &lt; and &gt;. You can check the above KTable&lt;byte[], Long&gt; aggregatedStream example => KTable<byte[], Long> aggregatedStream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@showuon thanks a lot! Fixed it.

Copy link
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarcoLotz
Copy link
Contributor Author

@showuon @mjsax is there anything missing to merge this to trunk?

@mjsax mjsax merged commit 63a6130 into apache:trunk Jul 7, 2022
@mjsax
Copy link
Member

mjsax commented Jul 7, 2022

Thanks for the PR! Merged to trunk.

ijuma added a commit to confluentinc/kafka that referenced this pull request Aug 3, 2022
> $ git merge-base apache-github/3.3 apache-github/trunk
> 23c92ce

> $ git show 23c92ce
> commit 23c92ce
> Author: SC <pch838811@gmail.com>
> Date:   Mon Jul 11 11:36:56 2022 +0900
>
>    MINOR: Use String#format for niceMemoryUnits result (apache#12389)
>
>    Reviewers: Luke Chen <showuon@gmail.com>, Divij Vaidya <diviv@amazon.com>

* commit '23c92ce79366e86ca719e5e51c550c27324acd83':
  MINOR: Use String#format for niceMemoryUnits result (apache#12389)
  KAFKA-14055; Txn markers should not be removed by matching records in the offset map (apache#12390)
  KAFKA-13474: Allow reconfiguration of SSL certs for broker to controller connection (apache#12381)
  KAFKA-13996: log.cleaner.io.max.bytes.per.second can be changed dynamically (apache#12296)
  KAFKA-13983: Fail the creation with "/" in resource name in zk ACL (apache#12359)
  KAFKA-12943: update aggregating documentation (apache#12091)
  KAFKA-13846: Follow up PR to address review comments (apache#12297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants