MINOR: Remove ReplicaManagerTest.initializeLogAndTopicId#12276
Merged
jsancio merged 1 commit intoapache:trunkfrom Jun 14, 2022
Merged
MINOR: Remove ReplicaManagerTest.initializeLogAndTopicId#12276jsancio merged 1 commit intoapache:trunkfrom
jsancio merged 1 commit intoapache:trunkfrom
Conversation
divijvaidya
reviewed
Jun 9, 2022
Contributor
There was a problem hiding this comment.
I think if this unused, we should remove it ?
Member
Author
There was a problem hiding this comment.
No :) The test doesn't pass without this line. Fixed.
The workaround is not required with mockito.
ijuma
force-pushed
the
remove-easymock-hack-replica-manager-test
branch
from
5c96617 to
22251a9
Compare
Kvicii
approved these changes
Jun 9, 2022
Contributor
There was a problem hiding this comment.
I think if this unused, we should remove it ?
Member
|
The failing test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workaround is not required with mockito.
Committer Checklist (excluded from commit message)