KAFKA-14004: Migrate streams module to JUnit 5 - Part 3#12302
Closed
clolov wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-14004: Migrate streams module to JUnit 5 - Part 3#12302clolov wants to merge 1 commit intoapache:trunkfrom
clolov wants to merge 1 commit intoapache:trunkfrom
Conversation
clolov
commented
Jun 16, 2022
| .replace('=', '_'); | ||
| } | ||
|
|
||
| public static String safeUniqueTestName(final Class<?> testClass, final TestInfo testInfo) { |
Contributor
Author
There was a problem hiding this comment.
The file streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java is only added in this pull request for the build to succeed. It will be removed once #12285 is merged.
clolov
commented
Jun 16, 2022
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| @Category(IntegrationTest.class) | ||
| public class KStreamKStreamOuterJoinTest { |
Contributor
Author
There was a problem hiding this comment.
I believe this test was not running before due to the lack of @category annotation.
clolov
commented
Jun 16, 2022
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| @Category(IntegrationTest.class) | ||
| public class KStreamKStreamLeftJoinTest { |
Contributor
Author
There was a problem hiding this comment.
I believe this test was not running before due to the lack of @category annotation.
Contributor
Author
|
Politely bumping for a review @cadonna |
3 tasks
Member
|
It looks like this has been done in https://issues.apache.org/jira/browse/KAFKA-15623. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses https://issues.apache.org/jira/browse/KAFKA-14004. It is the third of a series of pull requests which address the move of Kafka Streams tests from JUnit 4 to JUnit 5.
This pull request will be rebased on top of #12285 once it is merged. The file streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java is only added in this pull request for the build to succeed.
Committer Checklist (excluded from commit message)