MINOR: change Streams topic-level metrics tag from 'topic-name' to 'topic'#12310
Merged
cadonna merged 4 commits intoapache:trunkfrom Jun 21, 2022
Conversation
Kvicii
approved these changes
Jun 20, 2022
cadonna
approved these changes
Jun 21, 2022
Member
cadonna
left a comment
cadonna
left a comment
There was a problem hiding this comment.
LGTM!
I restarted the builds to verify whether the failures where related.
Member
|
Build failures are unrelated: |
cadonna
pushed a commit
to confluentinc/ksql
that referenced
this pull request
Jun 22, 2022
Followup to apache/kafka#12310 to fix the tests and remove the temporary hack for converting the topic-name tag to just topic Reviewer: Bruno Cadonna <bruno@confluent.io>
mjsax
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jun 30, 2022
…opic' (apache#12310) Changes the tag name from topic-name to just topic to conform to the way this tag is named elsewhere (ie in the clients) Also: - fixes a comment about dynamic topic routing - fixes some indentation in MockRecordCollector - Undoes the changes to KStreamSplitTest.scala and TestTopicsTest which are no longer necessary after this hotfix Reviewers: Bruno Cadonna <cadonna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the tag name from
topic-nameto justtopicto conform to the way this tag is named elsewhere (ie in the clients)Also addresses the followup feedback from @cadonna on the original PR:
MockRecordCollectorKStreamSplitTest.scalaandTestTopicsTestwhich are no longer necessary after this hotfix