Skip to content

MINOR: Update comment on verifyTaskGenerationAndOwnership method in DistributedHerder #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
C0urante merged 1 commit into from
Jul 28, 2022
Merged

MINOR: Update comment on verifyTaskGenerationAndOwnership method in DistributedHerder #12451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,9 +1732,7 @@ private boolean startTask(ConnectorTaskId taskId) {
throw ConnectUtils.maybeWrap(cause, "Failed to perform round of zombie fencing");
}
},
() -> {
verifyTaskGenerationAndOwnership(taskId, taskGeneration);
}
() -> verifyTaskGenerationAndOwnership(taskId, taskGeneration)
);
} else {
return worker.startSourceTask(
Expand Down Expand Up @@ -1941,8 +1939,8 @@ private void reconfigureConnector(final String connName, final Callback<Void> cb
}
}

// Currently unused, but will be invoked by exactly-once source tasks after they have successfully
// initialized their transactional producer
// Invoked by exactly-once worker source tasks after they have successfully initialized their transactional
// producer to ensure that it is still safe to bring up the task
private void verifyTaskGenerationAndOwnership(ConnectorTaskId id, int initialTaskGen) {
log.debug("Reading to end of config topic to ensure it is still safe to bring up source task {} with exactly-once support", id);
if (!refreshConfigSnapshot(Long.MAX_VALUE)) {
Expand Down