Skip to content

MINOR: Remove code of removed metric #12453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cadonna merged 1 commit into from
Jul 29, 2022
Merged

MINOR: Remove code of removed metric #12453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions ...ams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ private ThreadMetrics() {}
private static final String PUNCTUATE = "punctuate";
private static final String CREATE_TASK = "task-created";
private static final String CLOSE_TASK = "task-closed";
private static final String SKIP_RECORD = "skipped-records";
private static final String BLOCKED_TIME = "blocked-time-ns-total";
private static final String THREAD_START_TIME = "thread-start-time";

Expand Down Expand Up @@ -79,9 +78,6 @@ private ThreadMetrics() {}
private static final String PUNCTUATE_RATE_DESCRIPTION = RATE_DESCRIPTION + PUNCTUATE_DESCRIPTION;
private static final String PUNCTUATE_AVG_LATENCY_DESCRIPTION = "The average punctuate latency";
private static final String PUNCTUATE_MAX_LATENCY_DESCRIPTION = "The maximum punctuate latency";
private static final String SKIP_RECORDS_DESCRIPTION = "skipped records";
private static final String SKIP_RECORD_TOTAL_DESCRIPTION = TOTAL_DESCRIPTION + SKIP_RECORDS_DESCRIPTION;
private static final String SKIP_RECORD_RATE_DESCRIPTION = RATE_DESCRIPTION + SKIP_RECORDS_DESCRIPTION;
private static final String COMMIT_OVER_TASKS_DESCRIPTION =
"calls to commit over all tasks assigned to one stream thread";
private static final String COMMIT_OVER_TASKS_TOTAL_DESCRIPTION = TOTAL_DESCRIPTION + COMMIT_OVER_TASKS_DESCRIPTION;
Expand Down Expand Up @@ -123,18 +119,6 @@ public static Sensor closeTaskSensor(final String threadId,
);
}

public static Sensor skipRecordSensor(final String threadId,
final StreamsMetricsImpl streamsMetrics) {
return invocationRateAndCountSensor(
threadId,
SKIP_RECORD,
SKIP_RECORD_RATE_DESCRIPTION,
SKIP_RECORD_TOTAL_DESCRIPTION,
RecordingLevel.INFO,
streamsMetrics
);
}

public static Sensor commitSensor(final String threadId,
final StreamsMetricsImpl streamsMetrics) {
return invocationRateAndCountAndAvgAndMaxLatencySensor(
Expand Down
2 changes: 0 additions & 2 deletions ...src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,6 @@ public void shouldGetPunctuateRatioSensor() {
assertThat(sensor, is(expectedSensor));
}
}

@Test
public void shouldGetCreateTaskSensor() {
final String operation = "task-created";
final String totalDescription = "The total number of newly created tasks";
Expand Down