Skip to content

KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest #12468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 2 commits into from
Aug 3, 2022
Merged

KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest #12468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcd8962
fix flakiness
guozhangwang Aug 2, 2022
c9f65fb
github comments
guozhangwang Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ public RecordQueue createQueue(final TopicPartition partition) {
final SourceNode<?, ?> source = topology.source(partition.topic());
if (source == null) {
throw new TopologyException(
"Topic is unknown to the topology. " +
"Topic " + partition.topic() + " is unknown to the topology. " +
Copy link
Contributor Author

@guozhangwang guozhangwang Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is piggy-backed improvement when I tried to debug the failure: it's better to log the missing topic name as well.

"This may happen if different KafkaStreams instances of the same application execute different Topologies. " +
"Note that Topologies are only identical if all operators are added in the same order."
);
Expand Down
14 changes: 7 additions & 7 deletions streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
import static java.util.Arrays.asList;
import static java.util.Collections.singletonList;
import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.safeUniqueTestName;
import static org.apache.kafka.test.TestUtils.waitForCondition;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

@Timeout(600)
@Tag("integration")
Expand Down Expand Up @@ -143,13 +143,13 @@ public void shouldDoRebalancingWithMaximumNumberOfClientTags() throws Exception
createAndStart(clientTags2, clientTagKeys, numberOfStandbyReplicas);

waitUntilAllKafkaStreamsClientsAreRunning();
assertTrue(isIdealTaskDistributionReachedForTags(clientTagKeys));
waitForCondition(() -> isIdealTaskDistributionReachedForTags(clientTagKeys), "not all tags are evenly distributed");

stopKafkaStreamsInstanceWithIndex(0);

waitUntilAllKafkaStreamsClientsAreRunning();

assertTrue(isIdealTaskDistributionReachedForTags(clientTagKeys));
waitForCondition(() -> isIdealTaskDistributionReachedForTags(clientTagKeys), "not all tags are evenly distributed");
}

@Test
Expand All @@ -165,7 +165,7 @@ public void shouldDistributeStandbyReplicasWhenAllClientsAreLocatedOnASameCluste
createAndStart(buildClientTags(TAG_VALUE_EU_CENTRAL_1B, TAG_VALUE_K8_CLUSTER_1), asList(TAG_ZONE, TAG_CLUSTER), numberOfStandbyReplicas);

waitUntilAllKafkaStreamsClientsAreRunning();
assertTrue(isIdealTaskDistributionReachedForTags(singletonList(TAG_ZONE)));
waitForCondition(() -> isIdealTaskDistributionReachedForTags(singletonList(TAG_ZONE)), "not all tags are evenly distributed");
}

@Test
Expand All @@ -186,7 +186,7 @@ public void shouldDistributeStandbyReplicasOverMultipleClientTags() throws Excep
createAndStart(buildClientTags(TAG_VALUE_EU_CENTRAL_1C, TAG_VALUE_K8_CLUSTER_3), asList(TAG_ZONE, TAG_CLUSTER), numberOfStandbyReplicas);

waitUntilAllKafkaStreamsClientsAreRunning();
assertTrue(isIdealTaskDistributionReachedForTags(asList(TAG_ZONE, TAG_CLUSTER)));
waitForCondition(() -> isIdealTaskDistributionReachedForTags(asList(TAG_ZONE, TAG_CLUSTER)), "not all tags are evenly distributed");
}

@Test
Expand All @@ -204,8 +204,8 @@ public void shouldDistributeStandbyReplicasWhenIdealDistributionCanNotBeAchieved

waitUntilAllKafkaStreamsClientsAreRunning();

assertTrue(isIdealTaskDistributionReachedForTags(singletonList(TAG_ZONE)));
assertTrue(isPartialTaskDistributionReachedForTags(singletonList(TAG_CLUSTER)));
waitForCondition(() -> isIdealTaskDistributionReachedForTags(singletonList(TAG_ZONE)), "not all tags are evenly distributed");
waitForCondition(() -> isPartialTaskDistributionReachedForTags(singletonList(TAG_CLUSTER)), "not all tags are evenly distributed");
}

private void stopKafkaStreamsInstanceWithIndex(final int index) {
Expand Down