Conversation
This reverts commit 5f85c8e
Author
|
Fix has been merged : #12483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[KAFKA-14115] Password configs are logged in plaintext in KRaft
While updating the config for a broker ConfigurationControlManager is logging sensitive config values (listener.name.external.ssl.key.password).
ConfigResource(type=BROKER, name='1'): set configuration listener.name.external.ssl.key.password to bar
We need to redact these values the same as BrokerMetadataPublisher
Updating broker 1 with new configuration : listener.name.external.ssl.key.password -> [hidden]
Changes: updated isSensitive method to check if the config name contains the string password and used the same while logging config values.
@mumrah Can you please review this PR ?