Skip to content

KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly #12609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsancio merged 2 commits into from
Sep 9, 2022
Merged

KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly #12609

jsancio merged 2 commits into from
Sep 9, 2022

Conversation

@ijuma
Copy link
Member

@ijuma ijuma commented Sep 8, 2022

Verified that the artifact generated by releaseTarGz no longer includes
swagger-jaxrs2 or its dependencies (like snakeyaml).

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jsancio
Copy link
Member

jsancio commented Sep 8, 2022

Thanks for the PR @ijuma . What do think @showuon @C0urante @mimaison?

@C0urante
Copy link
Contributor

C0urante commented Sep 8, 2022

This appears to break the docs generation added in #12067; running ./gradlew siteDocsTar with this change causes the generated docs/generated/connect_rest.yaml file to lose all information on the REST API save for general metadata.

Are we okay with spending some time on trying to fix the docs generation, or does this need to be merged ASAP to unblock the 3.3 release?

@jsancio
Copy link
Member

jsancio commented Sep 8, 2022

Are we okay with spending some time on trying to fix the docs generation, or does this need to be merged ASAP to unblock the 3.3 release?

@C0urante I am open to suggestions on how to fix this. We have a couple of days to fix the issue. Do you have time to look into this?

@C0urante
Copy link
Contributor

C0urante commented Sep 8, 2022

Yeah, I can try to find something. Thanks José!

C0urante
C0urante reviewed Sep 8, 2022
View reviewed changes
@ijuma @C0urante
Update build.gradle
616e4db 
Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
jsancio
jsancio approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@jsancio jsancio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran ./gradlew siteDocsTar and the generated docs/generated/connect_rest.yaml looks okay to me.

C0urante
C0urante approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsancio jsancio merged commit b449b80 into apache:trunk Sep 9, 2022
jsancio pushed a commit that referenced this pull request Sep 9, 2022
@ijuma @jsancio
KAFKA-14198; swagger-jaxrs2 dependency should be compileOnly (#12609)
1eedaca 
Verified that the artifact generated by `releaseTarGz` no longer includes
swagger-jaxrs2 or its dependencies (like snakeyaml).

Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>, Chris Egerton <fearthecellos@gmail.com>
@C0urante C0urante mentioned this pull request Sep 9, 2022
Merged
3 tasks
@C0urante
Copy link
Contributor

C0urante commented Sep 9, 2022

Filed #12616 as a non-urgent follow-up to remove the combined compile-time and runtime classpath hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@C0urante C0urante C0urante approved these changes

@jsancio jsancio jsancio approved these changes

@mimaison mimaison Awaiting requested review from mimaison

@showuon showuon Awaiting requested review from showuon

Assignees

No one assigned

Labels

connect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijuma @jsancio @C0urante