Revert "KAFKA-13891: reset generation when syncgroup failed with REBA…

[aiquestion]

…LANCE_IN_PROGRESS (#12140)"

This reverts commit c23d60d.

As discussed in KAFKA-14016.
The change in KAFKA-13891 will lead to revoke more partitions than expected. So revert it.

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[showuon]

LGTM! Thanks for the PR.

[dajac]

@showuon What's the plan with this one? I tend to agree that reverting it makes sense. Is there are reason why you did not merge it yet?

[showuon]

Ah, sorry, was waiting for jenkins build results, and ... forgot it.

[showuon]

Build results:

    Build / JDK 8 and Scala 2.12 / kafka.admin.TopicCommandIntegrationTest.testDeleteInternalTopic(String).quorum=kraft
    Build / JDK 8 and Scala 2.12 / kafka.api.TransactionsTest.testAbortTransactionTimeout(String).quorum=kraft
    Build / JDK 8 and Scala 2.12 / kafka.api.TransactionsTest.testCommitTransactionTimeout(String).quorum=zk
    Build / JDK 8 and Scala 2.12 / kafka.server.KRaftClusterTest.testCreateClusterAndPerformReassignment()
    Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testAbortTransactionTimeout(String).quorum=zk
    Build / JDK 11 and Scala 2.13 / kafka.api.SaslPlaintextConsumerTest.testCoordinatorFailover()
    Build / JDK 11 and Scala 2.13 / kafka.api.SaslScramSslEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe()
    Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsTest.testSendOffsetsToTransactionTimeout(String).quorum=kraft
    Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsTest.testAbortTransactionTimeout(String).quorum=kraft
    Build / JDK 11 and Scala 2.13 / kafka.server.KRaftClusterTest.testCreateClusterAndPerformReassignment()
    Build / JDK 11 and Scala 2.13 / kafka.server.KRaftClusterTest.testUnregisterBroker()
    Build / JDK 11 and Scala 2.13 / kafka.server.KRaftClusterTest.testUpdateMetadataVersion()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.IQv2StoreIntegrationTest.verifyStore[cache=false, log=false, supplier=ROCKS_WINDOW, kind=DSL]
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldNotMakeStoreAvailableUntilAllStoresAvailable
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.SlidingWindowedKStreamIntegrationTest.shouldRestoreAfterJoinRestart[ON_WINDOW_UPDATE_cache:false]
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

I felt all are unrelated, but this test: kafka.api.TransactionsTest.testAbortTransactionTimeout failed in 3 jobs. I re-trigger the test now. Waiting for the result.
@aiquestion , in case I'll forget it, please remind me after build completed. :)

[dajac]

Last build had two failures:

Build / JDK 11 and Scala 2.13 / testLargeAssignmentAndGroupWithNonEqualSubscription() – org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest
1m 16s
Build / JDK 17 and Scala 2.13 / testTransactionAfterTransactionIdExpiresButProducerIdRemains(String).quorum=zk – kafka.api.ProducerIdExpirationTest

cc @showuon

[dajac]

@showuon Do we need to backport it to previous releases as well?

[showuon]

Good point. We backed port the fix to 3.2 and 3.3 branch in #12140 . Let me backport to 3.2/3.3. Thanks for reminding.