KAFKA-13709: Add docs for exactly-once support in Connect#12941
KAFKA-13709: Add docs for exactly-once support in Connect#12941C0urante merged 12 commits intoapache:trunkfrom
Conversation
|
@joel-hamill would you be interested in taking a look at this? |
Hi @C0urante :) I spoke with @joel-hamill. I can take a look if you like. 👍 |
|
That'd be great! Thanks @tikimims |
docs/connect.html
Outdated
There was a problem hiding this comment.
| <p>If a sink connector supports exactly-once delivery, all that is necessary to enable exactly-once delivery at the Connect worker level is ensuring that its consumer group is configured to ignore records in aborted transactions. This can be done by setting the worker property <code>consumer.isolation.level</code> to <code>read_committed</code> or, if running a version of Kafka Connect that supports it, using a <a href="#connectconfigs_connector.client.config.override.policy">connector client config override policy</a> that allows the <code>consumer.override.isolation.level</code> property to be set to <code>read_committed</code> in individual connector configs. There are no additional ACL requirements.</p> | |
| <p>If a sink connector supports exactly-once delivery and to enable exactly-once delivery at the Connect worker level, you must ensure its consumer group is configured to ignore records in aborted transactions. You can do this by setting the worker property <code>consumer.isolation.level</code> to <code>read_committed</code> or, if running a version of Kafka Connect that supports it, using a <a href="#connectconfigs_connector.client.config.override.policy">connector client config override policy</a> that allows the <code>consumer.override.isolation.level</code> property to be set to <code>read_committed</code> in individual connector configs. There are no additional ACL requirements.</p> |
There was a problem hiding this comment.
This one I don't quite grasp--the change from
If a sink connector supports exactly-once delivery, all that is necessary to enable exactly-once delivery
to
If a sink connector supports exactly-once delivery and to enable exactly-once delivery
doesn't seem quite right. The rest of the suggestion makes sense.
@tikimims can you help me understand this part better? Was it an accident?
There was a problem hiding this comment.
(I've pushed the suggested changes here except for the bit described above)
There was a problem hiding this comment.
Recommend reordering this sentence to: "For more information on this feature, see the <a href..."
|
Hi @C0urante I took a first pass and left some suggestions. :) Let me know if you'd like me to take another pass after any updates. 👍 |
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
Co-authored-by: tikimims <39631000+tikimims@users.noreply.github.com>
|
Thanks @tikimims! I've accepted all but one of the suggestions and asked for clarification on the other. I didn't realize how common usage of "you" and "your" in the docs were; switching to that wording really helps tidy things up! |
|
Hi @mimaison @tombentley would either of you have time to take a look at this? |
|
Thanks Mickael! |
Reviewers: Mickael Maison <mickael.maison@gmail.com>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
Jira
Adds administrator- and developer-facing documentation on the features introduced in KIP-618.
Rebased on top of #12938 to fix recently-introduced compilation failures on trunk.