KAFKA-14279; Add 3.3.x streams system tests by jsancio · Pull Request #13077 · apache/kafka

jsancio · 2023-01-04T20:42:41Z

Add 3.3.x stream upgrade tests. The streams/upgrade-system-tests-33 directory was created by coping streams/upgrade-system-tests-32 without changes.

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

jsancio · 2023-01-04T20:43:18Z

@cadonna can you review this PR?

Running system tests on this branch.

jsancio · 2023-01-05T18:36:38Z

Here are the system test results: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1672893494--jsancio--kafka-14545-stream-3-3-test--a595bcfb9c/2023-01-04--001./2023-01-04--001./report.html

Looks like this test failed:

Module: kafkatest.tests.streams.streams_upgrade_test
Class:  StreamsUpgradeTest
Method: test_rolling_upgrade_with_2_bounces
Arguments:
{
  "from_version": "3.3.1",
  "to_version": "3.5.0-SNAPSHOT"
}

I am going to rerun just this test.

mjsax

A few minor comments.

mjsax · 2023-01-05T19:50:27Z

...upgrade-system-tests-33/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java

+
+        final Properties streamsProperties = Utils.loadProps(propFileName);
+
+        System.out.println("StreamsTest instance started (StreamsUpgradeTest v3.2)");


Suggested change

System.out.println("StreamsTest instance started (StreamsUpgradeTest v3.2)");

System.out.println("StreamsTest instance started (StreamsUpgradeTest v3.3)");

mjsax · 2023-01-05T19:51:10Z

...upgrade-system-tests-33/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java

+
+            @Override
+            public void init(final ProcessorContext<KOut, VOut> context) {
+                System.out.println("[3.2] initializing processor: topic=" + topic + "taskId=" + context.taskId());


Suggested change

System.out.println("[3.2] initializing processor: topic=" + topic + "taskId=" + context.taskId());

System.out.println("[3.3] initializing processor: topic=" + topic + "taskId=" + context.taskId());

mjsax · 2023-01-05T19:51:21Z

streams/upgrade-system-tests-33/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java

+            @Override
+            public void init(final ProcessorContext<Void, Void> context) {
+                super.init(context);
+                System.out.println("[3.2] initializing processor: topic=" + topic + " taskId=" + context.taskId());


Suggested change

System.out.println("[3.2] initializing processor: topic=" + topic + " taskId=" + context.taskId());

System.out.println("[3.3] initializing processor: topic=" + topic + " taskId=" + context.taskId());

jsancio · 2023-01-05T20:44:29Z

Same failure again: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1672950817--jsancio--kafka-14545-stream-3-3-test--a595bcfb9c/2023-01-05--001./2023-01-05--001./report.html

TimeoutError('Could not detect Kafka Streams version 3.5.0-SNAPSHOT on ubuntu@worker29')

…ream-3-3-test

mjsax · 2023-01-06T21:57:22Z

@jsancio -- any update?

jsancio · 2023-01-10T00:23:23Z

@mjsax I got a chance to work on this today. I updated the PR. Here is the result from running the test locally:

TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py::StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces" _DUCKTAPE_OPTIONS='--parameters '\''{"from_version":"3.3.1","to_version":"3.5.0-SNAPSHOT"}'\' tests/docker/run_tests.sh

> Configure project :
Starting build with version 3.5.0-SNAPSHOT (commit id a0090d24) using Gradle 7.6, Java 1.8 and Scala 2.13.10
Build properties: maxParallelForks=12, maxScalacThreads=8, maxTestRetries=0

BUILD SUCCESSFUL in 1s
168 actionable tasks: 168 up-to-date
docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file /opt/kafka-dev/tests/docker/build/cluster.json  ./tests/kafkatest/tests/streams/streams_upgrade_test.py::StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces --parameters '{"from_version":"3.3.1","to_version":"3.5.0-SNAPSHOT"}'"
/usr/local/lib/python3.9/dist-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
  "class": algorithms.Blowfish,
[INFO:2023-01-09 16:14:29,112]: starting test run with session id 2023-01-09--003...
[INFO:2023-01-09 16:14:29,112]: running 1 tests...
[INFO:2023-01-09 16:14:29,112]: Triggering test 1 of 1...
[INFO:2023-01-09 16:14:29,117]: RunnerClient: Loading test {'directory': '/opt/kafka-dev/tests/kafkatest/tests/streams', 'file_name': 'streams_upgrade_test.py', 'cls_name': 'StreamsUpgradeTest', 'method_name': 'test_rolling_upgrade_with_2_bounces', 'injected_args': {'from_version': '3.3.1', 'to_version': '3.5.0-SNAPSHOT'}}
[INFO:2023-01-09 16:14:29,118]: RunnerClient: kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=3.3.1.to_version=3.5.0-SNAPSHOT: on run 1/1
[INFO:2023-01-09 16:14:29,119]: RunnerClient: kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=3.3.1.to_version=3.5.0-SNAPSHOT: Setting up...
[INFO:2023-01-09 16:14:29,119]: RunnerClient: kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=3.3.1.to_version=3.5.0-SNAPSHOT: Running...
[INFO:2023-01-09 16:18:09,123]: RunnerClient: kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=3.3.1.to_version=3.5.0-SNAPSHOT: Tearing down...
[INFO:2023-01-09 16:18:28,193]: RunnerClient: kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=3.3.1.to_version=3.5.0-SNAPSHOT: PASS
[INFO:2023-01-09 16:18:28,193]: RunnerClient: kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=3.3.1.to_version=3.5.0-SNAPSHOT: Data: None
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.1
session_id:       2023-01-09--003
run time:         3 minutes 59.087 seconds
tests run:        1
passed:           1
flaky:            0
failed:           0
ignored:          0
================================================================================
test_id:    kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=3.3.1.to_version=3.5.0-SNAPSHOT
status:     PASS
run time:   3 minutes 59.075 seconds
--------------------------------------------------------------------------------

mjsax · 2023-01-10T07:39:24Z

Thanks for the PR. Merged to trunk and cherry-picked to 3.4 branch.

Reviewers: Matthias J. Sax <matthias@confluent.io>

* apache-github/trunk: KAFKA-14601: Improve exception handling in KafkaEventQueue apache#13089 KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface (apache#12886) KAFKA-14530: Check state updater more often (apache#13017) KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record (apache#13103) KAFKA-14003 Kafka Streams JUnit4 to JUnit5 migration part 2 (apache#12301) KAFKA-14607: Move Scheduler/KafkaScheduler to server-common (apache#13092) KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface (apache#12870) KAFKA-14557; Lock metadata log dir (apache#13058) MINOR: Implement toString method for TopicAssignment and PartitionAssignment (apache#13101) KAFKA-12558: Do not prematurely mutate internal partition state in Mirror Maker 2 (apache#11818) KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer (apache#13032) KAFKA-14600: Reduce flakiness in ProducerIdExpirationTest (apache#13087) KAFKA-14279: Add 3.3.x streams system tests (apache#13077) MINOR: bump streams quickstart pom versions and add to list in gradle.properties (apache#13064) MINOR: Update KRaft cluster upgrade documentation for 3.4 (apache#13063) KAFKA-14493: Introduce Zk to KRaft migration state machine STUBs in KRaft controller. (apache#12998) KAFKA-14570: Fix parenthesis in verifyFullFetchResponsePartitions output (apache#13072) MINOR: Remove public mutable fields from ProducerAppendInfo (apache#13091)

Reviewers: Matthias J. Sax <matthias@confluent.io>

KAFKA-14545; Add 3.3.x streams system tests

a595bcf

jsancio changed the title ~~KAFKA-14545; Add 3.3.x streams system tests~~ KAFKA-14279; Add 3.3.x streams system tests Jan 5, 2023

mjsax added streams tests Test fixes (including flaky tests) labels Jan 5, 2023

mjsax reviewed Jan 5, 2023

View reviewed changes

jsancio added 2 commits January 5, 2023 12:54

KAFKA-14279; Print the 3.3 version in the log messages

568c730

Merge remote-tracking branch 'apache-kafka/trunk' into kafka-14545-st…

a0090d2

…ream-3-3-test

KAFKA-14279; Fix StreamsConfig

1720840

mjsax merged commit 896573f into apache:trunk Jan 10, 2023

mjsax pushed a commit that referenced this pull request Jan 10, 2023

KAFKA-14279: Add 3.3.x streams system tests (#13077)

c991a2d

Reviewers: Matthias J. Sax <matthias@confluent.io>

jsancio deleted the kafka-14545-stream-3-3-test branch January 10, 2023 18:09

guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023

KAFKA-14279: Add 3.3.x streams system tests (apache#13077)

91c897f

Reviewers: Matthias J. Sax <matthias@confluent.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KAFKA-14279; Add 3.3.x streams system tests#13077

KAFKA-14279; Add 3.3.x streams system tests#13077
mjsax merged 4 commits intoapache:trunkfrom
jsancio:kafka-14545-stream-3-3-test

jsancio commented Jan 4, 2023

Uh oh!

jsancio commented Jan 4, 2023

Uh oh!

jsancio commented Jan 5, 2023

Uh oh!

mjsax left a comment

Uh oh!

mjsax Jan 5, 2023

Uh oh!

mjsax Jan 5, 2023

Uh oh!

mjsax Jan 5, 2023

Uh oh!

jsancio commented Jan 5, 2023

Uh oh!

mjsax commented Jan 6, 2023

Uh oh!

jsancio commented Jan 10, 2023

Uh oh!

mjsax commented Jan 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		final Properties streamsProperties = Utils.loadProps(propFileName);

		System.out.println("StreamsTest instance started (StreamsUpgradeTest v3.2)");

	System.out.println("[3.2] initializing processor: topic=" + topic + "taskId=" + context.taskId());
	System.out.println("[3.3] initializing processor: topic=" + topic + "taskId=" + context.taskId());

Conversation

jsancio commented Jan 4, 2023

Committer Checklist (excluded from commit message)

Uh oh!

jsancio commented Jan 4, 2023

Uh oh!

jsancio commented Jan 5, 2023

Uh oh!

mjsax left a comment

Choose a reason for hiding this comment

Uh oh!

mjsax Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

mjsax Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

mjsax Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

jsancio commented Jan 5, 2023

Uh oh!

mjsax commented Jan 6, 2023

Uh oh!

jsancio commented Jan 10, 2023

Uh oh!

mjsax commented Jan 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants