Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

/**
* This class represents the in-memory state of segments associated with a leader epoch. This includes the mapping of offset to
* segment ids and unreferenced segments which are not mapped to any offset but they exist in remote storage.
* segment ids and unreferenced segments which are not mapped to any offset, but they exist in remote storage.
* <p>
* This is used by {@link RemoteLogMetadataCache} to track the segments for each leader epoch.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ private void handleSegmentWithDeleteSegmentFinishedState(RemoteLogSegmentMetadat
(leaderEpoch, remoteLogLeaderEpochState, startOffset, segmentId) ->
remoteLogLeaderEpochState.handleSegmentWithDeleteSegmentFinishedState(segmentId));

// Remove the segment's id to metadata mapping because this segment is considered as deleted and it cleared all
// Remove the segment's id to metadata mapping because this segment is considered as deleted, and it cleared all
// the state of this segment in the cache.
idToSegmentMetadata.remove(remoteLogSegmentMetadata.remoteLogSegmentId());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class RemoteLogSegmentMetadataSnapshot extends RemoteLogMetadata {
private final long endOffset;

/**
* Maximum timestamp in milli seconds in the segment
* Maximum timestamp in milliseconds in the segment
*/
private final long maxTimestampMs;

Expand Down Expand Up @@ -82,9 +82,9 @@ public class RemoteLogSegmentMetadataSnapshot extends RemoteLogMetadata {
* @param segmentId Universally unique remote log segment id.
* @param startOffset Start offset of this segment (inclusive).
* @param endOffset End offset of this segment (inclusive).
* @param maxTimestampMs Maximum timestamp in milli seconds in this segment.
* @param maxTimestampMs Maximum timestamp in milliseconds in this segment.
* @param brokerId Broker id from which this event is generated.
* @param eventTimestampMs Epoch time in milli seconds at which the remote log segment is copied to the remote tier storage.
* @param eventTimestampMs Epoch time in milliseconds at which the remote log segment is copied to the remote tier storage.
* @param segmentSizeInBytes Size of this segment in bytes.
* @param state State of the respective segment of remoteLogSegmentId.
* @param segmentLeaderEpochs leader epochs occurred within this segment.
Expand Down Expand Up @@ -149,7 +149,7 @@ public int segmentSizeInBytes() {
}

/**
* @return Maximum timestamp in milli seconds of a record within this segment.
* @return Maximum timestamp in milliseconds of a record within this segment.
*/
public long maxTimestampMs() {
return maxTimestampMs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
/**
* This is the {@link RemoteLogMetadataManager} implementation with storage as an internal topic with name {@link TopicBasedRemoteLogMetadataManagerConfig#REMOTE_LOG_METADATA_TOPIC_NAME}.
* This is used to publish and fetch {@link RemoteLogMetadata} for the registered user topic partitions with
* {@link #onPartitionLeadershipChanges(Set, Set)}. Each broker will have an instance of this class and it subscribes
* {@link #onPartitionLeadershipChanges(Set, Set)}. Each broker will have an instance of this class, and it subscribes
* to metadata updates for the registered user topic partitions.
*/
public class TopicBasedRemoteLogMetadataManager implements RemoteLogMetadataManager {
Expand Down Expand Up @@ -466,7 +466,7 @@ private NewTopic createRemoteLogMetadataTopicRequest() {

/**
* @param topic topic to be created.
* @return Returns true if the topic already exists or it is created successfully.
* @return Returns true if the topic already exists, or it is created successfully.
*/
private boolean createTopic(AdminClient adminClient, NewTopic topic) {
boolean topicCreated = false;
Expand Down