MINOR: the package of JmxTool is incorrect when running quota_test.py#13233
Merged
chia7712 merged 1 commit intoapache:trunkfrom Feb 12, 2023
Merged
MINOR: the package of JmxTool is incorrect when running quota_test.py#13233chia7712 merged 1 commit intoapache:trunkfrom
chia7712 merged 1 commit intoapache:trunkfrom
Conversation
fvaleri
approved these changes
Feb 12, 2023
Contributor
fvaleri
left a comment
There was a problem hiding this comment.
@chia7712 LGTM.
Thanks for fixing this and sorry if it caused any inconvenience.
I ran every failing ST from this branch on my local machine.
TC_PATHS="tests/kafkatest/tests/core/mirror_maker_test.py::TestMirrorMakerService.test_bounce" \
_DUCKTAPE_OPTIONS='--parameters '\''{"clean_shutdown":"false","security_protocol":"PLAINTEXT"}'\' \
bash tests/docker/run_tests.sh
--------------------------------------------------------------------------------
test_id: kafkatest.tests.core.mirror_maker_test.TestMirrorMakerService.test_bounce.clean_shutdown=false.security_protocol=PLAINTEXT
status: PASS
run time: 2 minutes 41.021 seconds
--------------------------------------------------------------------------------
TC_PATHS="tests/kafkatest/tests/client/quota_test.py::QuotaTest.test_quota" \
bash tests/docker/run_tests.sh
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=.user.client-id.override_quota=False
status: PASS
run time: 4 minutes 55.564 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=.user.client-id.override_quota=True
status: PASS
run time: 2 minutes 54.707 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.consumer_num=2
status: PASS
run time: 3 minutes 41.160 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.old_broker_throttling_behavior=True
status: PASS
run time: 2 minutes 47.152 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.old_client_throttling_behavior=True
status: PASS
run time: 2 minutes 52.824 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.override_quota=False
status: PASS
run time: 4 minutes 57.153 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.override_quota=True
status: PASS
run time: 2 minutes 54.194 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=user.override_quota=False
status: PASS
run time: 3 minutes 57.129 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=user.override_quota=True
status: PASS
run time: 3 minutes 6.432 seconds
--------------------------------------------------------------------------------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #13136
JmxToolwas moved fromkafka.tools.JmxTooltoorg.apache.kafka.tools.JmxTool.Committer Checklist (excluded from commit message)