KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records by vamossagar12 · Pull Request #13801 · apache/kafka

Commits on Apr 4, 2024

KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

Sagar Rao
authored and
Sagar Rao
committed
Removing blocking calls on secondary store writes plus added more testes

Sagar Rao
authored and
Sagar Rao
committed
Adding explicit wait for secondary writes future with tombstone records

Sagar Rao
authored and
Sagar Rao
committed
Simplifying tombstone presence check

Sagar Rao
authored and
Sagar Rao
committed
Removing unwanted change from tests

Sagar Rao
authored and
Sagar Rao
committed
Fixing checkstyle

Sagar Rao
authored and
Sagar Rao
committed
Addressing review comments

Sagar Rao
authored and
Sagar Rao
committed
Adding missing exception print block

Sagar Rao
authored and
Sagar Rao
committed
Further review comments addressed

Sagar Rao
authored and
Sagar Rao
committed
Removing duplicate callback and removing ConnectorOffsetBackingStore from suppressions.xml

Sagar Rao
authored and
Sagar Rao
committed
Minor review comments addressed

Sagar Rao
authored and
Sagar Rao
committed
Using KafkaFuture to return only one future object back to caller

Sagar Rao
authored and
Sagar Rao
committed
Separate test class for ConnectorOffsetBackingStore + one single Future object to be returned to the caller

Sagar Rao
authored and
Sagar Rao
committed
Removing completableFuture.complete call and refactoring tests

Sagar Rao
authored and
Sagar Rao
committed
Fixing checkstyle

Sagar Rao
authored and
Sagar Rao
committed
Replacing thenApply with thenAccept and setting callback oncompletion directly within thenAccept

Sagar Rao
authored and
Sagar Rao
committed
Addressing review comments

Sagar Rao
authored and
Sagar Rao
committed

Commits on Apr 5, 2024

Removing CompletableFuture and using a single future which writes to both primary and secindary future

Sagar Rao
authored and
Sagar Rao
committed

Commits on Apr 10, 2024

Commits on Apr 11, 2024

Creating a separate Future to return from secondary store writes + refactored tests

Sagar Rao
authored and
Sagar Rao
committed
Removing unused variable and import

Sagar Rao
authored and
Sagar Rao
committed
Updating writeError variable name to primaryWriteError

Sagar Rao
authored and
Sagar Rao
committed

Commits on Apr 13, 2024

Fixing checkstyle issues

Sagar Rao
authored and
Sagar Rao
committed

Commits on Apr 25, 2024

Adding a chained future callback and making the producer in the tests asynchronous

Sagar Rao
authored and
Sagar Rao
committed

Commits on May 3, 2024

Modifying tests to consider offsets writes involving both regular and tombstone offsets

Sagar Rao
authored and
Sagar Rao
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records#13801

KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records#13801
C0urante merged 28 commits intoapache:trunkfrom
vamossagar12:KAFKA-15018

Commits on Apr 4, 2024

KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

Removing blocking calls on secondary store writes plus added more testes

Adding explicit wait for secondary writes future with tombstone records

Simplifying tombstone presence check

Removing unwanted change from tests

Fixing checkstyle

Addressing review comments

Adding missing exception print block

Further review comments addressed

Removing duplicate callback and removing ConnectorOffsetBackingStore from suppressions.xml

Minor review comments addressed

Using KafkaFuture to return only one future object back to caller

Separate test class for ConnectorOffsetBackingStore + one single Future object to be returned to the caller

Removing completableFuture.complete call and refactoring tests

Fixing checkstyle

Replacing thenApply with thenAccept and setting callback oncompletion directly within thenAccept

Addressing review comments

Commits on Apr 5, 2024

Removing CompletableFuture and using a single future which writes to both primary and secindary future

Commits on Apr 10, 2024

Update connect/runtime/src/test/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStoreTest.java

Update connect/runtime/src/test/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStoreTest.java

Update connect/runtime/src/test/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStoreTest.java

Removing try catch from tests and validating outside callback

Commits on Apr 11, 2024

Creating a separate Future to return from secondary store writes + refactored tests

Removing unused variable and import

Updating writeError variable name to primaryWriteError

Commits on Apr 13, 2024

Fixing checkstyle issues

Commits on Apr 25, 2024

Adding a chained future callback and making the producer in the tests asynchronous

Commits on May 3, 2024

Modifying tests to consider offsets writes involving both regular and tombstone offsets