MINOR:Avoid slow Set.removeAll(List) in MirrorSourceConnector#13992
MINOR:Avoid slow Set.removeAll(List) in MirrorSourceConnector#13992gharris1727 merged 2 commits intoapache:trunkfrom
Conversation
|
Please help to review this minor pr, thanks! @gharris1727 |
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java
Show resolved
Hide resolved
|
Thanks for the fix @hudeqi ! I was wondering if you had plans to address this problem/warning elsewhere in the codebase? |
I did a global search for the |
gharris1727
left a comment
There was a problem hiding this comment.
LGTM. Thanks @hudeqi for addressing this in both of the Mirror connectors!
|
The flaky CI failures look unrelated and the mirror unit tests pass locally. |
…e#13992) Reviewed-by: Greg Harris <greg.harris@aiven.io>
similar to #13946. The
refreshTopicPartitionsmethod is called periodically. When the number of partitions involved in replication is large, performance problems may occur.