Skip to content

KAFKA-15222: Upgrade zinc Scala incremental compiler plugin version to a latests stable fit version (1.9.2)#14060

Merged
divijvaidya merged 1 commit intoapache:trunkfrom
bmscomp:dependencies/upgrade_zinc_compiler
Jul 21, 2023
Merged

KAFKA-15222: Upgrade zinc Scala incremental compiler plugin version to a latests stable fit version (1.9.2)#14060
divijvaidya merged 1 commit intoapache:trunkfrom
bmscomp:dependencies/upgrade_zinc_compiler

Conversation

@bmscomp
Copy link
Contributor

@bmscomp bmscomp commented Jul 20, 2023

The existing version of zinc incremental scala compiler plugin is getting a bit old, upgrading to last stable version 1.9.2

From the version 1.8.0 to 1.9.2 this is a list of all changed sbt/zinc@v1.8.0...v1.9.2
Link to release notes : https://github.com/sbt/zinc/releases

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@divijvaidya
Copy link
Member

Please add link to release notes explaining the difference amongst version.

@bmscomp
Copy link
Contributor Author

bmscomp commented Jul 20, 2023

@divijvaidya I am working on it right now, I have a good resource sbt/zinc@v1.8.0...v1.9.2

@bmscomp bmscomp force-pushed the dependencies/upgrade_zinc_compiler branch from 6570d54 to 74b4ebe Compare July 20, 2023 12:25
@bmscomp
Copy link
Contributor Author

bmscomp commented Jul 20, 2023

The current pull request CI, the errors related to zinc appeared again in current Jenkins build, rebasing the branch again will run the build again, the strange behaviour is that the related locked zinc file is pointing to an old version of it

I am checking now the behaviour of the build, wait and see

@bmscomp
Copy link
Contributor Author

bmscomp commented Jul 20, 2023

@divijvaidya It's ok now, things seems more stable, but there is some failure on building kafak with jdk 20 that has no relation with zinc compiler,

Notice that for all build the retry_zinc step is without issue

@bmscomp
Copy link
Contributor Author

bmscomp commented Jul 20, 2023

@divijvaidya No breaking changes are mentioned in the release notes, meanwhile much upgrades and bug fixing are present till the version 1.8.0 I can mention the most important of them

  • Infinite Compile Fix (1.8.1)
  • Fix writing zip64's offset (1.9.1)
  • Update scala-compiler, scala-library to 2.13.10 to fix CVE (1.9.0)
  • Use NIO to create temp file (1.8.1)

It's far better to use the new version

Copy link
Member

@divijvaidya divijvaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed effort here! Lgtm. I will merge this tomorrow after giving other folks a chance to look into this PR

@divijvaidya divijvaidya merged commit e9fc742 into apache:trunk Jul 21, 2023
jeqo pushed a commit to jeqo/kafka that referenced this pull request Jul 21, 2023
Reviewers: Divij Vaidya <diviv@amazon.com>
@bmscomp bmscomp deleted the dependencies/upgrade_zinc_compiler branch July 21, 2023 09:26
Cerchie pushed a commit to Cerchie/kafka that referenced this pull request Jul 25, 2023
Reviewers: Divij Vaidya <diviv@amazon.com>
jeqo pushed a commit to aiven/kafka that referenced this pull request Aug 15, 2023
Reviewers: Divij Vaidya <diviv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants