Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" #14738

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

dajac
Copy link
Contributor

@dajac dajac commented Nov 11, 2023

This reverts commit f38b0d8.

Trying to find the root cause of org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest failing in CI.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac
Copy link
Contributor Author

dajac commented Nov 11, 2023

JDK 21 and Scala 2.13 build failed due to #14739.

@dajac
Copy link
Contributor Author

dajac commented Nov 11, 2023

org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest does not fail without this commit. We should revert it for the time being.

@dajac
Copy link
Contributor Author

dajac commented Nov 11, 2023

The failed build is due to #14739.

@dajac dajac changed the title (Ignore) Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" Nov 11, 2023
@dajac dajac marked this pull request as ready for review November 11, 2023 13:50
@dajac dajac requested a review from ijuma November 11, 2023 15:45
@dajac dajac unassigned ijuma Nov 11, 2023
@jolshan
Copy link
Contributor

jolshan commented Nov 12, 2023

org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest does not fail without this commit. We should revert it for the time being.

Here are existing builds where it was already failing -- I see that the error is different though. This is why I probably thought it was a non-issue.
https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/2371/#showFailuresLink
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14695/6/

@jolshan jolshan merged commit a98bd7d into apache:trunk Nov 12, 2023
1 check failed
@dajac dajac deleted the revert-kafka-15661 branch November 12, 2023 08:38
chb2ab added a commit to chb2ab/kafka that referenced this pull request Nov 15, 2023
jolshan pushed a commit that referenced this pull request Nov 16, 2023
…14738)" (#14747)

This KIP-951 commit was reverted to investigate the org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest test failure (#14738).

A fix for that was merged in #14757, hence unreverting this change.

This reverts commit a98bd7d.

Reviewers: Justine Olshan <jolshan@confluent.io>, Mayank Shekhar Narula <mayanks.narula@gmail.com>
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request Jan 2, 2024
…ache#14738)

This reverts commit f38b0d8.

Trying to find the root cause of org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest failing in CI.

Reviewers: Justine Olshan <jolshan@confluent.io>
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request Jan 2, 2024
…)" (apache#14738)" (apache#14747)

This KIP-951 commit was reverted to investigate the org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest test failure (apache#14738).

A fix for that was merged in apache#14757, hence unreverting this change.

This reverts commit a98bd7d.

Reviewers: Justine Olshan <jolshan@confluent.io>, Mayank Shekhar Narula <mayanks.narula@gmail.com>
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
…ache#14738)

This reverts commit f38b0d8.

Trying to find the root cause of org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest failing in CI.

Reviewers: Justine Olshan <jolshan@confluent.io>
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
…)" (apache#14738)" (apache#14747)

This KIP-951 commit was reverted to investigate the org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest test failure (apache#14738).

A fix for that was merged in apache#14757, hence unreverting this change.

This reverts commit a98bd7d.

Reviewers: Justine Olshan <jolshan@confluent.io>, Mayank Shekhar Narula <mayanks.narula@gmail.com>
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
…ache#14738)

This reverts commit f38b0d8.

Trying to find the root cause of org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest failing in CI.

Reviewers: Justine Olshan <jolshan@confluent.io>
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
…)" (apache#14738)" (apache#14747)

This KIP-951 commit was reverted to investigate the org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest test failure (apache#14738).

A fix for that was merged in apache#14757, hence unreverting this change.

This reverts commit a98bd7d.

Reviewers: Justine Olshan <jolshan@confluent.io>, Mayank Shekhar Narula <mayanks.narula@gmail.com>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
…ache#14738)

This reverts commit f38b0d8.

Trying to find the root cause of org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest failing in CI.

Reviewers: Justine Olshan <jolshan@confluent.io>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
…)" (apache#14738)" (apache#14747)

This KIP-951 commit was reverted to investigate the org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest test failure (apache#14738).

A fix for that was merged in apache#14757, hence unreverting this change.

This reverts commit a98bd7d.

Reviewers: Justine Olshan <jolshan@confluent.io>, Mayank Shekhar Narula <mayanks.narula@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants