KAFKA-15819: Fix leaked KafkaRaftManager in ZK mode during migration #14751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Harris <greg.harris@aiven.io>
3 tasks
cmccabe
approved these changes
Nov 27, 2023
Contributor
cmccabe
left a comment
cmccabe
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @gharris1727
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…e#14751) The other call sites for KafkaRaftManager (SharedServer, TestRaftServer, MetadataShell) appear to shutdown the KafkaRaftManager when shutting down themselves. The call-site in ZK-mode KafkaServer should behave the same way. Reviewers: Colin P. McCabe <cmccabe@apache.org>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
…e#14751) The other call sites for KafkaRaftManager (SharedServer, TestRaftServer, MetadataShell) appear to shutdown the KafkaRaftManager when shutting down themselves. The call-site in ZK-mode KafkaServer should behave the same way. Reviewers: Colin P. McCabe <cmccabe@apache.org>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…e#14751) The other call sites for KafkaRaftManager (SharedServer, TestRaftServer, MetadataShell) appear to shutdown the KafkaRaftManager when shutting down themselves. The call-site in ZK-mode KafkaServer should behave the same way. Reviewers: Colin P. McCabe <cmccabe@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other call sites for KafkaRaftManager (SharedServer, TestRaftServer, MetadataShell) appear to shutdown the KafkaRaftManager when shutting down themselves. The call-site in ZK-mode KafkaServer should behave the same way.
Committer Checklist (excluded from commit message)