KAFKA-15816: Fix leaked sockets in core tests #14754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Harris <greg.harris@aiven.io>
3 tasks
Contributor
Author
|
Even through the CI appears to have all of these tests pass, I'm getting some strange failures locally that i'll need to investigate more before merge. |
Contributor
Author
|
It looks like the consistent failures I was seeing were present only on JDK21, didn't reproduce with JDK11, but were already present on trunk. I got some flakey failures with JDK11 locally, but they appear unrelated. |
showuon
pushed a commit
to showuon/kafka
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Mickael Maison <mickael.maison@gmail.com>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Mickael Maison <mickael.maison@gmail.com>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Mickael Maison <mickael.maison@gmail.com>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Mickael Maison <mickael.maison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests leak sockets due to various typos. Additionally, many tests leaked sockets because MiniKdc stops asynchronously, leaving sockets open at the end of the test which are eventually cleaned up. This patch uses the alternative dispose method which awaits termination of the internal resources of the KDC before proceeding with the normal shutdown.
Committer Checklist (excluded from commit message)