Skip to content

Conversation

@gharris1727
Copy link
Contributor

These socket leaks were caused by typos, either an extra call to start() or a missing call to close().

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727 gharris1727 changed the title KAFKA-15816: Fix leaked sockets in mirror KAFKA-15816: Fix leaked sockets in mirror tests Nov 14, 2023
@gharris1727 gharris1727 added the tests Test fixes (including flaky tests) label Nov 14, 2023
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@gharris1727
Copy link
Contributor Author

Test failures appear unrelated.

@gharris1727 gharris1727 merged commit a2d596c into apache:trunk Dec 6, 2023
gaurav-narula pushed a commit to gaurav-narula/kafka that referenced this pull request Jan 24, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mirror-maker-2 tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants