-
Notifications
You must be signed in to change notification settings - Fork 14.9k
KAFKA-15816: Fix leaked sockets in runtime tests #14764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
divijvaidya
merged 4 commits into
apache:trunk
from
gharris1727:kafka-15816-runtime-tests-leak-sockets
Jan 1, 2024
Merged
KAFKA-15816: Fix leaked sockets in runtime tests #14764
divijvaidya
merged 4 commits into
apache:trunk
from
gharris1727:kafka-15816-runtime-tests-leak-sockets
Jan 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Harris <greg.harris@aiven.io>
3 tasks
mimaison
approved these changes
Dec 5, 2023
Member
mimaison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…est cleanup Signed-off-by: Greg Harris <greg.harris@aiven.io>
Signed-off-by: Greg Harris <greg.harris@aiven.io>
…end-of-test cleanup" This reverts commit 9cb074e.
Member
|
Unrelated test failures, all tests modified in this PR are successful. |
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
This commit fixes to prevent socket leaks, mostly through clients that are left open. Reviewers: Mickael Maison <mickael.maison@gmail.com>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
This commit fixes to prevent socket leaks, mostly through clients that are left open. Reviewers: Mickael Maison <mickael.maison@gmail.com>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
This commit fixes to prevent socket leaks, mostly through clients that are left open. Reviewers: Mickael Maison <mickael.maison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests contain typos that leak sockets, mostly through clients that are left open.
The WorkerTest had rather involved resource leaks, which arose because the typical lifetime of the WorkerTask was partially or totally mocked. The WorkerTask subclass constructors accept clients as arguments, and take ownership of those clients, and the partial mocking prevented those clients from being closed appropriately.
Now, all of (WorkerSourceTask, ExactlyOnceWorkerSourceTask, WorkerSinkTask) have their constructors mocked, and those constructors close the passed-in resources immediately. This also allows the test to avoid waiting for some cancellation timeouts to expire, making the test faster to run.
The other systematic typo that was present was the OffsetStore not being configured or closed, which caused a consumer to be leaked. This is because the constructor is instantiated in the factory method (e.g. offsetStoreForExactlyOnceSourceTask), but the KafkaOffsetBackingStore.offsetLog field field is only initialized inside of configure(WorkerConfig). Rather than making OffsetBackingStore implementations close the consumer even when configure is not called, I made the test use a more realistic lifecycle and actually call configure(WorkerConfig) and stop().
Committer Checklist (excluded from commit message)