KAFKA-15816: Fix leaked sockets in streams tests #14769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Harris <greg.harris@aiven.io>
3 tasks
mjsax
reviewed
Nov 19, 2023
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the PR! Very nice to get these leaks fixed.
| }) | ||
| ); | ||
|
|
||
| // do not use the harness streams |
Member
There was a problem hiding this comment.
Not sure what this comment means?
Contributor
Author
There was a problem hiding this comment.
I changed this, let me know if the new comment makes more sense or if you'd like it removed.
I was indicating that the KafkaStreams that the test harness set up for the test won't be used, and a different KafkaStreams was being substituted.
streams/src/test/java/org/apache/kafka/streams/integration/MetricsReporterIntegrationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Contributor
Author
|
The streams test failures appear unrelated, as they are not subclasses of the changed tests, and all streams tests pass locally. |
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Matthias J. Sax <mjsax@apache.org>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Matthias J. Sax <mjsax@apache.org>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Matthias J. Sax <mjsax@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests leak sockets via Kafka clients, either directly or via KafkaStreams instances. The tests should close these resources when appropriate.
Committer Checklist (excluded from commit message)