KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect#14979
Closed
Phuc-Hong-Tran wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect#14979Phuc-Hong-Tran wants to merge 1 commit intoapache:trunkfrom
Phuc-Hong-Tran wants to merge 1 commit intoapache:trunkfrom
Conversation
…eThrowAuthFailure, and tryConnect
Contributor
Author
|
@kirktrue, Can I have a review for this PR? Thanks in advance. |
Contributor
Author
|
@philipnee PTAL, the context for this one is here: #14406 (comment) |
Contributor
|
thanks. seems like all test aborted, let me reopen the pr to trigger the tests |
Contributor
Author
|
hm let's me try again, the ci failed to start it seems |
Contributor
Author
|
@philipnee do you think I should close this one and open a new PR instead? the ci doesn't seem to restart after we close and re-open this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
*Refactored
AbstractFetchso onlyFetcherwill check for node status when creating fetch requests.Committer Checklist (excluded from commit message)