improve log description of QuorumController #15926
Conversation
|
Hey, @mumrah ! When you have free time, could you take a look? 🙇♂️ |
There was a problem hiding this comment.
Thanks for picking this up @chickenchickenlove 👍
Left a suggestion for the log message
| @@ -165,6 +165,8 @@ static ControllerResult<Void> recordsForNonEmptyLog( | |||
| throw new RuntimeException("Should not have ZK migrations enabled on a cluster that was " + | |||
| "created in KRaft mode."); | |||
| } | |||
| logMessageBuilder | |||
| .append("since this is a de-novo KRaft cluster."); | |||
There was a problem hiding this comment.
How about "This is expected because this is a de-novo KRaft cluster." ?
There was a problem hiding this comment.
This is better 👍
I make a new commit to apply your comments.
Please take another look, when you have free time 🙇♂️
There was a problem hiding this comment.
@mumrah gently ping.
When you have free time, please take another look?
Thanks in advance! 🙇♂️
| @@ -165,6 +165,8 @@ static ControllerResult<Void> recordsForNonEmptyLog( | |||
| throw new RuntimeException("Should not have ZK migrations enabled on a cluster that was " + | |||
| "created in KRaft mode."); | |||
| } | |||
| logMessageBuilder | |||
| .append("This is expected because this is a de-novo KRaft cluster."); | |||
There was a problem hiding this comment.
nit: remove the unnecessary line break here
There was a problem hiding this comment.
@mumrah , i make new commit to apply your comments.
However, the CI still is failed.
The changes which i made seems not to be related with failure of CI.
Am i wrong?
|
I started a new build here https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15926/6/ |
Thanks for your comments. |
|
Test failures look unrelated. Merging |
|
Hey, mumrah. |
Motivation
QuorumControllerwarn with "Performing controller activation. Loaded ZK migration state of NONE" even if it'sde-novoKRaft cluster. That message makes operator confused, and operator might waste time investigating that log. If we add some description to log, operator will be more convenient.Modification
de-novo KRaftcluster whenzookeeper.metadata.migration.enable=falseand the broker version supportsKRaft.Result