KAFKA-16916: Fixing error in completing future #16249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableegoldman
reviewed
Jun 8, 2024
There was a problem hiding this comment.
FYI the PR to disable the test was already merged, so you'll need to re-enable it. See #16248
I don't have too much context on this but if the PR build passes without timing out (once you've renabled the test) then I'd say we merge it
Sure, I have enabled the test and checked locally the tests are passing. Shall wait for build to complete.
|
3 tasks
|
The Ci test completed without timeout. |
showuon
approved these changes
Jun 8, 2024
This was referenced Jun 8, 2024
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
Fix to complete Future which was stuck due the exception.getCause() throws an error. The fix in the apache#16217 unblocked blocking thread but exception in catch block from blocking get call was wrapped in ExecutionException which is not the case when moved to async workflow hence getCause is not needed. Reviewers: Luke Chen <showuon@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
Fix to complete Future which was stuck due the exception.getCause() throws an error. The fix in the apache#16217 unblocked blocking thread but exception in catch block from blocking get call was wrapped in ExecutionException which is not the case when moved to async workflow hence getCause is not needed. Reviewers: Luke Chen <showuon@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
jlprat
pushed a commit
to jlprat/kafka
that referenced
this pull request
Jul 15, 2024
Fix to complete Future which was stuck due the exception.getCause() throws an error. The fix in the apache#16217 unblocked blocking thread but exception in catch block from blocking get call was wrapped in ExecutionException which is not the case when moved to async workflow hence getCause is not needed. Reviewers: Luke Chen <showuon@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to complete Future which was stuck due the
exception.getCause()throws an error.The fix in the #16217 unblocked blocking thread but
exceptionincatchblock from blockinggetcall was wrapped inExecutionExceptionwhich is not the case when moved to async workflow hencegetCauseis not needed.Committer Checklist (excluded from commit message)