Skip to content

KAFKA-16791: Add thread detection to ClusterTestExtensions #16427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bboyleonp666 wants to merge 2 commits into from
Closed

KAFKA-16791: Add thread detection to ClusterTestExtensions #16427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50538fd
add beforeall and afterall support: wip
trend-leon-wang Jun 23, 2024
68915c3
Fix style error
trend-leon-wang Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion core/src/test/java/kafka/test/ClusterTestExtensionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.extension.ExtendWith;

import kafka.utils.TestUtils;
import org.junit.jupiter.api.extension.AfterAllCallback;
import org.junit.jupiter.api.extension.BeforeAllCallback;
import org.junit.jupiter.api.extension.ExtensionContext;

import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
Expand All @@ -56,14 +61,24 @@
@ClusterConfigProperty(id = 0, key = "queued.max.requests", value = "100"),
}) // Set defaults for a few params in @ClusterTest(s)
@ExtendWith(ClusterTestExtensions.class)
public class ClusterTestExtensionsTest {
public class ClusterTestExtensionsTest implements BeforeAllCallback, AfterAllCallback {

private final ClusterInstance clusterInstance;

ClusterTestExtensionsTest(ClusterInstance clusterInstance) { // Constructor injections
this.clusterInstance = clusterInstance;
}

@Override
public void afterAll(ExtensionContext extent) throws Exception {
TestUtils.verifyNoUnexpectedThreads("@AfterAllCallback");
}

@Override
public void beforeAll(ExtensionContext context) throws Exception {
TestUtils.verifyNoUnexpectedThreads("@BeforeAllCallback");
}

// Static methods can generate cluster configurations
static List<ClusterConfig> generate1() {
Map<String, String> serverProperties = new HashMap<>();
Expand Down