KAFKA-17204: KafkaStreamsCloseOptionsIntegrationTest.before leaks AdminClient #16692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianetm
reviewed
Jul 26, 2024
| @AfterAll | ||
| public static void closeCluster() { | ||
| if (adminClient != null) { | ||
| adminClient.close(); |
Member
There was a problem hiding this comment.
what about doing this quietly (reusing Utils.closeQuietly)
Contributor
Author
There was a problem hiding this comment.
That would be more concise, thanks for the suggestion 😄
lianetm
reviewed
Jul 26, 2024
.../test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @lianetm |
3 tasks
Member
|
Thanks for the fix @frankvicky! Merged to |
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…inClient (apache#16692) To avoid a resource leak, we need to close the AdminClient after the test. Reviewers: Lianet Magrans <lianetmr@gmail.com>, Matthias J. Sax <matthias@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid resource leak, we should close
AdminClientafter test.Committer Checklist (excluded from commit message)