KAFKA-17532: Moved ShareGroupConfig to share module #17176
+122
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -954,6 +956,8 @@ project(':share') { | |||
|
|
|||
| dependencies { | |||
| implementation project(':server-common') | |||
| implementation project(':clients') | |||
| implementation project(':coordinator-common') | |||
There was a problem hiding this comment.
Isn't there is a cycle i.e. coordinator-common requires server, server requires share and share requires coordinator-common?
apoorvmittal10
suggested changes
Sep 12, 2024
| @@ -40,6 +40,9 @@ | |||
|
|
|||
| <subpackage name="coordinator"> | |||
| <subpackage name="common"> | |||
|
|
|||
| <allow pkg="org.apache.kafka.common" /> | |||
There was a problem hiding this comment.
Line number 34 - 39 above defines common classes. Which common package do we need explitily, can we please include that above.
| @@ -33,6 +33,9 @@ | |||
| <!-- anyone can use public classes --> | |||
| <allow pkg="org.apache.kafka.common" exact-match="true" /> | |||
| <allow pkg="org.apache.kafka.common.utils" /> | |||
| <allow pkg="org.apache.kafka.common.config" /> | |||
| <allow pkg="org.apache.kafka.common.errors" /> | |||
| <allow pkg="org.apache.kafka.coordinator.common" /> | |||
There was a problem hiding this comment.
Seems not the right section to include coordinator.
| @@ -202,7 +202,7 @@ public void testSupportedNewGroupProtocols(ClusterInstance clusterInstance) { | |||
|
|
|||
| @ClusterTests({ | |||
| @ClusterTest(types = {Type.ZK, Type.KRAFT, Type.CO_KRAFT}, serverProperties = { | |||
| @ClusterConfigProperty(key = GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value = "classic"), | |||
| @ClusterConfigProperty(key = GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value = "Classic"), | |||
There was a problem hiding this comment.
Why this change is required?
| @@ -72,7 +72,7 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness { | |||
| cfgs.foreach(_.setProperty(KRaftConfigs.MIGRATION_ENABLED_CONFIG, "true")) | |||
| } | |||
| if (isShareGroupTest()) { | |||
| cfgs.foreach(_.setProperty(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, "classic,consumer,share")) | |||
| cfgs.foreach(_.setProperty(CoordinatorCommonConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, "Classic,Consumer,Share")) | |||
There was a problem hiding this comment.
Why do we need to change "Classic,Consumer,Share"?
| @@ -43,7 +44,7 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstance) { | |||
| @ClusterTest( | |||
| types = Array(Type.KRAFT), | |||
| serverProperties = Array( | |||
| new ClusterConfigProperty(key = GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value = "classic"), | |||
| new ClusterConfigProperty(key = CoordinatorCommonConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value = "Classic"), | |||
There was a problem hiding this comment.
Agains same is Classic change is required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the ShareGroupConfig has been moved to the share package. Since the config
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIGfromGroupCoordinatorConfigis required inShareGroupConfig, andsharecannot depend ongroup-coordinator,GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIGhas been moved to a separate config file calledCoordinatorCommonConfigincoordinator-commonReference - KAFKA-17532