KAFKA-17488: Cleanup (test) code for Kafka Streams "metric version" #17182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @mjsax! Could you review it? :) |
fonsdant
commented
Sep 13, 2024
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Sep 13, 2024
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
Outdated
Show resolved
Hide resolved
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
Outdated
Show resolved
Hide resolved
...a/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregateProcessorTest.java
Show resolved
Hide resolved
...c/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java
Show resolved
Hide resolved
fonsdant
force-pushed
the
cleanup-code-for-kafka-streams-metric-version
branch
from
9e59c9a
to
c9c47dd
Compare
mjsax
reviewed
Sep 26, 2024
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
Show resolved
Hide resolved
|
Thanks for the update. Overall LGTM -- one more minor question. |
|
Accidentally, I must have reverted the removal of the Also, I have removed the others |
|
Thanks for the PR @fonsdant! Merged to trunk. |
bbejeck
pushed a commit
to bbejeck/kafka
that referenced
this pull request
Sep 28, 2024
…pache#17182) This PR simply StreamsMetricsImpl to avoid passing in the unused "metric version" parameter. Reviewers: Matthias J. Sax <matthias@confluent.io>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Sep 30, 2024
…pache#17182) This PR simply StreamsMetricsImpl to avoid passing in the unused "metric version" parameter. Reviewers: Matthias J. Sax <matthias@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We note that
StreamsMetricsImplis created with the default valueVersion.LATESTand only usebuiltInMetricsVersionto pass it toObjects.requireNonNull. So I have removedbuiltInMetricsVersionfromStreamsMetricsImplas well as removedBUILT_IN_METRICS_VERSION_CONFIGandBUILT_IN_METRICS_VERSION_DOCsince they became unused.I have based this work on KIP-444 and KIP-743.