KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes #17198
+24
−997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsdant
changed the title
|
I have missed removing the references to |
|
I have noticed that |
fonsdant
force-pushed
the
kstream-transform-remove-deprecated-transformer-methods-and-classes
branch
from
2d4b7f4
to
bafaa10
Compare
added 6 commits
September 17, 2024 20:16
fonsdant
force-pushed
the
kstream-transform-remove-deprecated-transformer-methods-and-classes
branch
from
bafaa10
to
f28ac72
Compare
|
For now, I have removed the build with deduplicaiton topology test until we decide how to replace the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @mjsax! I have removed the
transformmethods from the main and test classes. However, I have asked myself whether the approach I have used forStandbyTaskEOSIntegrationTestandStreamThreadTestis correct. Should I replacetransformwithprocessas suggested intransformJavadoc or remove these tests? Thanks!