KAFKA-17529: Remove blacklist from MM2 #17202

chiacyu · 2024-09-15T15:07:23Z

As titled, check KAFKA-17529 for details.
Please take a look, thanks!

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

chia7712 · 2024-09-15T16:17:03Z

@chiacyu thanks for your patch. Could you please cleanup the test of

kafka/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConfigTest.java

Line 70 in c958654

public void testConfigBackwardsCompatibility() {

Also, please update upgrade.html

chia7712

@chiacyu thanks for your patch. please check testConfigBackwardsCompatibility also

chia7712 · 2024-09-17T20:08:35Z

docs/upgrade.html

@@ -51,6 +51,18 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
                The <code>--whitelist</code> option was removed from the <code>kafka-console-consumer</code> command line tool.
                Please use <code>--include</code> instead.
            </li>
+            <li>
+                The <code>--whitelist</code> option was removed from the <code>kafka-console-consumer</code> command line tool.


Please remove this unrelated change

chia7712

@chiacyu thanks for updated patch. Could you please remove groups.blacklist also?

chia7712 · 2024-09-19T17:19:26Z

connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConfigTest.java

@@ -69,8 +69,8 @@ public void testConfigPropertyMatching() {
    @Test
    public void testConfigBackwardsCompatibility() {


we don't need this test because the blacklist-related configs are removed, right?

chia7712

@chiacyu thanks for your updates

chia7712 · 2024-09-23T03:06:16Z

docs/upgrade.html

+                Please use <code>config.properties.exclude</code> instead.
+            </li>
+            <li>
+                The <code>topics.blacklist</code> was removed from the <code>kafka.connect.mirror.MirrorSourceConfig</code>


org.apache.kafka.connect.mirror.MirrorSourceConfig

chia7712 · 2024-09-23T03:06:19Z

docs/upgrade.html

+                Please use <code>topics.exclude</code> instead.
+            </li>
+            <li>
+                The <code>groups.blacklist</code> was removed from the <code>kafka.connect.mirror.MirrorSourceConfig</code>


org.apache.kafka.connect.mirror.MirrorSourceConfig

chia7712 · 2024-09-23T03:06:24Z

docs/upgrade.html

@@ -51,6 +51,18 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
                The <code>--whitelist</code> option was removed from the <code>kafka-console-consumer</code> command line tool.
                Please use <code>--include</code> instead.
            </li>
+            <li>
+                The <code>config.properties.blacklist</code> was removed from the <code>kafka.connect.mirror.MirrorSourceConfig</code>


org.apache.kafka.connect.mirror.MirrorSourceConfig

chia7712

@chiacyu thanks for updates

chia7712 · 2024-09-24T17:04:25Z

connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultGroupFilter.java

-                    null,
-                    Importance.HIGH,
-                    "Deprecated. Use " + GROUPS_EXCLUDE_CONFIG + " instead.");
+                    GROUPS_EXCLUDE_DOC);

        GroupFilterConfig(Map<String, ?> props) {
            super(DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{


we don't need to call translateDeprecatedConfigs now, since the deprecated configs are removed

chia7712 · 2024-09-24T17:04:28Z

connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java

@@ -89,7 +83,7 @@ static class ConfigPropertyFilterConfig extends AbstractConfig {

        ConfigPropertyFilterConfig(Map<String, ?> props) {
            super(DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{


we don't need to call translateDeprecatedConfigs now, since the deprecated configs are removed

chia7712 · 2024-09-24T17:04:32Z

connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java

@@ -81,7 +80,7 @@ public class MirrorCheckpointConfig extends MirrorConnectorConfig {

    public MirrorCheckpointConfig(Map<String, String> props) {
        super(CONNECTOR_CONFIG_DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{


we don't need to call translateDeprecatedConfigs now, since the deprecated configs are removed

chia7712 · 2024-09-29T17:19:37Z

connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultTopicFilter.java

-                    null,
-                    Importance.HIGH,
-                    "Deprecated. Use " + TOPICS_EXCLUDE_CONFIG + " instead.");
+                    TOPICS_EXCLUDE_DOC);

        TopicFilterConfig(Map<String, ?> props) {
            super(DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{


it does not need translateDeprecatedConfigs, right?

…AFKA-17529

chia7712 · 2024-10-06T19:30:34Z

docs/upgrade.html

@@ -66,6 +75,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
                        <li>The <code>--whitelist</code> option was removed from the <code>kafka-console-consumer</code> command line tool.
                            Please use <code>--include</code> instead.
                        </li>
+                        <li>The <code>--delete-config</code> option in the <code>kafka-topics</code> command line tool has been deprecated.


Please remove the unnecessary changes

chia7712 · 2024-10-07T03:03:55Z

connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java

@@ -98,8 +96,8 @@ public class MirrorSourceConfig extends MirrorConnectorConfig {

    public MirrorSourceConfig(Map<String, String> props) {
        super(CONNECTOR_CONFIG_DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{


we don't need translateDeprecatedConfigs, right?

Removed blacklist from MM2

835a970

chiacyu added 2 commits September 17, 2024 16:57

fixed unit test and update docs

8da650e

Removed topic blacklist config

bc695ab

chia7712 reviewed Sep 17, 2024

View reviewed changes

Fixed unit test and restore doc

7112bae

chia7712 reviewed Sep 19, 2024

View reviewed changes

Removed group blacklist related config and test

baaef6a

github-actions bot added connect mirror-maker-2 labels Sep 22, 2024

chia7712 reviewed Sep 23, 2024

View reviewed changes

Updated with full class name

fbd0019

chia7712 reviewed Sep 24, 2024

View reviewed changes

Yu and others added 2 commits September 29, 2024 17:02

Removed the unneeded function call

ef3ed4e

Merge branch 'trunk' into KAFKA-17529

66706e1

chia7712 reviewed Sep 29, 2024

View reviewed changes

chia7712 added the ci-approved label Sep 29, 2024

chiacyu added 5 commits October 2, 2024 15:45

Fixed stylecheck and removed unneeded function call

848fcc9

Merge branch 'trunk' into KAFKA-17529

b5448d8

Removed duplicated doc info

c818332

Removed unneeded function calls

9b336c6

Merge branch 'KAFKA-17529' of https://github.com/chiacyu/kafka into K…

ebc4639

…AFKA-17529

TaiJuWu approved these changes Oct 6, 2024

View reviewed changes

chia7712 reviewed Oct 6, 2024

View reviewed changes

chiacyu added 2 commits October 7, 2024 08:32

Removed unrelated change

b8fd097

Add tage back

5fc1d98

chia7712 approved these changes Oct 7, 2024

View reviewed changes

chia7712 reviewed Oct 7, 2024

View reviewed changes

removed unneed function call

3d71484

chia7712 merged commit 9e809be into apache:trunk Oct 7, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KAFKA-17529: Remove blacklist from MM2 #17202

KAFKA-17529: Remove blacklist from MM2 #17202

chiacyu commented Sep 15, 2024

chia7712 commented Sep 15, 2024

chia7712 left a comment

chia7712 Sep 17, 2024

chia7712 left a comment

chia7712 Sep 19, 2024

chia7712 left a comment

chia7712 Sep 23, 2024

chia7712 Sep 23, 2024

chia7712 Sep 23, 2024

chia7712 left a comment

chia7712 Sep 24, 2024

chia7712 Sep 24, 2024

chia7712 Sep 24, 2024

chia7712 Sep 29, 2024

chia7712 Oct 6, 2024

chia7712 Oct 7, 2024

		@@ -69,8 +69,8 @@ public void testConfigPropertyMatching() {
		@Test
		public void testConfigBackwardsCompatibility() {

		@@ -89,7 +83,7 @@ static class ConfigPropertyFilterConfig extends AbstractConfig {

		ConfigPropertyFilterConfig(Map<String, ?> props) {
		super(DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{

		@@ -81,7 +80,7 @@ public class MirrorCheckpointConfig extends MirrorConnectorConfig {

		public MirrorCheckpointConfig(Map<String, String> props) {
		super(CONNECTOR_CONFIG_DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{

		@@ -98,8 +96,8 @@ public class MirrorSourceConfig extends MirrorConnectorConfig {

		public MirrorSourceConfig(Map<String, String> props) {
		super(CONNECTOR_CONFIG_DEF, ConfigUtils.translateDeprecatedConfigs(props, new String[][]{

KAFKA-17529: Remove blacklist from MM2 #17202

KAFKA-17529: Remove blacklist from MM2 #17202

Conversation

chiacyu commented Sep 15, 2024

Committer Checklist (excluded from commit message)

chia7712 commented Sep 15, 2024

chia7712 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chia7712 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chia7712 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chia7712 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment