MINOR: Fix SubscriptionResponseWrapperSerializer #17205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
commented
Sep 16, 2024
| @@ -46,7 +46,6 @@ default ProductionExceptionHandlerResponse handle(final ProducerRecord<byte[], b | |||
| * @param record The record that failed to produce | |||
| * @param exception The exception that occurred during production | |||
| */ | |||
| @SuppressWarnings("deprecation") | |||
| @@ -66,9 +66,8 @@ public void setIfUnset(final SerdeGetter getter) { | |||
| public byte[] serialize(final String topic, final SubscriptionResponseWrapper<V> data) { | |||
| //{1-bit-isHashNull}{7-bits-version}{Optional-16-byte-Hash}{n-bytes serialized data} | |||
|
|
|||
| //7-bit (0x7F) maximum for data version. | |||
| if (Byte.compare((byte) 0x7F, data.version()) < 0) { | |||
There was a problem hiding this comment.
This check is always false. Byte has a range from -128...127; thus, this comparison is incorrect.
| @@ -73,68 +69,95 @@ public T deserialize(final String topic, final byte[] data) { | |||
| } | |||
|
|
|||
| @Test | |||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
Side cleanup... (same other tests below)
| () -> new SubscriptionResponseWrapper<>(hashedValue, "foreignValue", (byte) 0xFF, 1)); | ||
| assertThrows( | ||
| UnsupportedVersionException.class, | ||
| () -> new SubscriptionResponseWrapper<>(hashedValue, "foreignValue", (byte) -1, 1) |
There was a problem hiding this comment.
Minor change for this test, too, passing in -1 now to make it more logical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.