Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17356 add IT for KAFKA-17310 #17211

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-17356 add IT for KAFKA-17310 #17211

wants to merge 3 commits into from

Conversation

brandboat
Copy link
Member

related to https://issues.apache.org/jira/browse/KAFKA-17356

KAFKA-17176 breaks the error handle but there is NO failed tests except for e2e. Hence, we should add IT for that case.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

chia7712
chia7712 reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandboat thanks for this nice test!

core/src/test/scala/unit/kafka/log/LogManagerTest.scala
Files.setPosixFilePermissions(logDir.toPath, permissions)

try {
logManager = assertDoesNotThrow(() => createLogManager())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the size of dirLocks? it should be 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandboat @chia7712