Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Log pending join members #17219

Merged
merged 1 commit into from
Sep 18, 2024
Merged

MINOR: Log pending join members #17219

merged 1 commit into from
Sep 18, 2024

Conversation

dajac
Copy link
Contributor

@dajac dajac commented Sep 18, 2024

I am still chasing KAFKA-17493. I was able to narrow it down to an issue with the pending join members. This patch logs them in order to help me troubleshooting it further. I will revert this change when the issue is root caused.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to ensure we revert this eventually, and assuming it's actually too verbose to ship with, can you file a blocker ticket for 4.0 just so we don't lose track?

Another approach would be to do a separate trace log with the extra info.

if(log.isTraceEnable()) { 
  log.trace(...) 
} else { 
  log.debug(...) 
}

Either way LGTM. Happy bug hunting :)

@dajac
Copy link
Contributor Author

dajac commented Sep 18, 2024

Sure thing: https://issues.apache.org/jira/browse/KAFKA-17571.

@dajac dajac merged commit 74bebf6 into trunk Sep 18, 2024
8 of 9 checks passed
@dajac dajac deleted the minor-log-pending-members branch September 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants