KAFKA-17558: Remove parameterization from streams integration tests #17315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
reviewed
Oct 1, 2024
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
...test/java/org/apache/kafka/streams/integration/JoinGracePeriodDurabilityIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
...ms/src/test/java/org/apache/kafka/streams/integration/ResetPartitionTimeIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
...src/test/java/org/apache/kafka/streams/integration/SuppressionDurabilityIntegrationTest.java
Outdated
Show resolved
Hide resolved
zzzk1
changed the title
exactly-once in stream integration tests
mjsax
reviewed
Oct 2, 2024
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
I am not sure why the Smoke Test failed. |
mjsax
reviewed
Oct 16, 2024
| final StreamsBuilder builder = new StreamsBuilder(); | ||
| builder.stream(SINGLE_PARTITION_INPUT_TOPIC).to(SINGLE_PARTITION_OUTPUT_TOPIC); | ||
|
|
||
| final Properties properties = new Properties(); | ||
| properties.put(StreamsConfig.PROCESSING_GUARANTEE_CONFIG, eosConfig); |
There was a problem hiding this comment.
Given that this is EosIntegerationTest we should run with EXACTLY_ONCE_V2, right?
Thank you for the reminder; it's improved. |
|
Thanks for the PR! Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fullow up #17110
exactly-oncevalue included in parameterizedResetPartitionTimeIntegrationTestRocksDBMetricsIntegrationTest.javaCommitter Checklist (excluded from commit message)