Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18039: Test all versions of quorum responses in RequestResponseTest #17873

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-18039: Test all versions of quorum responses in RequestResponseTest #17873

wants to merge 1 commit into from
+58 −7

Conversation

peterxcli
Copy link
Contributor

@peterxcli peterxcli commented Nov 20, 2024 •
edited
Loading

Following should support accepting version as they have more than one version

case BEGIN_QUORUM_EPOCH: return createBeginQuorumEpochResponse();
case END_QUORUM_EPOCH: return createEndQuorumEpochResponse();
case DESCRIBE_QUORUM: return createDescribeQuorumResponse();

Related links

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@peterxcli
feat: update response creation methods to accept version parameter
df4c1ea 
- Modified createDescribeQuorumResponse, createEndQuorumEpochResponse, and createBeginQuorumEpochResponse methods to accept a version parameter.
- Adjusted logic to set properties based on the version, ensuring compatibility with different response versions.
- Added node endpoint handling for EndQuorumEpochResponse and BeginQuorumEpochResponse based on version checks.
@github-actions github-actions bot added tests Test fixes (including flaky tests) clients small Small PRs labels Nov 20, 2024
@peterxcli
Copy link
Contributor Author

@ahuang98 Hi, This PR is ready, could you please take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clients small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterxcli