Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe #19055

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe #19055

wants to merge 2 commits into from
+57 −13

Conversation

DL1231
Copy link
Contributor

@DL1231 DL1231 commented Feb 28, 2025

1、Client support for TopicAuthException in DescribeShareGroup and HB path
2、ShareConsumerImpl#sendAcknowledgementsAndLeaveGroup swallow TopicAuthorizationException and GroupAuthorizationException

@github-actions github-actions bot added triage PRs from the community consumer clients small Small PRs labels Feb 28, 2025
@AndrewJSchofield AndrewJSchofield added KIP-932 Queues for Kafka ci-approved and removed triage PRs from the community labels Feb 28, 2025
AndrewJSchofield
AndrewJSchofield requested changes Feb 28, 2025
View reviewed changes
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just a few small comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShivsundarR ShivsundarR ShivsundarR left review comments

@AndrewJSchofield AndrewJSchofield AndrewJSchofield requested changes

Assignees
No one assigned
Labels
ci-approved clients consumer KIP-932 Queues for Kafka small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DL1231 @AndrewJSchofield @ShivsundarR