KAFKA-18854: remove DynamicConfig inner class
#19487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@gongxuanzhang please revise the title :) |
gongxuanzhang
changed the title
Contributor
Author
Thanks for your comment @chia7712 PTAL |
gongxuanzhang
changed the title
DynamicConfig User and DynamicConfig Client to server module
|
|
||
|
|
||
| public static class Client { | ||
| private static final ConfigDef CONFIG_DEF = QuotaConfig.userAndClientQuotaConfigs(); |
Member
There was a problem hiding this comment.
Could we rename this to CLIENT_CONFIGS, since it was clientConfigs?
chia7712
reviewed
Apr 16, 2025
| return USER_CONFIGS.names(); | ||
| } | ||
|
|
||
| public static Map<String, Object> validate(Properties props) { |
Member
There was a problem hiding this comment.
those method is useless, so please remove it.
| import java.util.Properties; | ||
| import java.util.Set; | ||
|
|
||
| public class DynamicConfig { |
Member
There was a problem hiding this comment.
those helpers are used by ConfigCommand only, so please remove inline this whole class.
github-actions
bot
added
small
Contributor
Author
|
@chia7712 PTAL |
Member
|
@gongxuanzhang could you please cleanup |
gongxuanzhang
changed the title
DynamicConfig User and DynamicConfig Client to server moduleDynamicConfig inner class
Contributor
Author
|
@chia7712 PTAL |
chia7712
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a umbrella of KAFKA-18854.
The previous PR encountered some compatibility issues, so we decided to
split it and proceed with the migration step by step.
see #19019
Reviewers: PoAn Yang payang@apache.org, Chia-Ping Tsai
chia7712@gmail.com